Re: [PATCH 4/6 v2] autofs4: factor should_expire() out of autofs4_expire_indirect.

2014-07-16 Thread NeilBrown
On Wed, 16 Jul 2014 15:50:17 +0800 Ian Kent wrote: > > + if (simple_empty(dentry)) > > + return NULL; > > + > > + /* Case 2: tree mount, expire iff entire tree is not busy */ > > + if (!exp_leaves) { > > + /* Path walk currently on this dentry? */ > > + ino_co

Re: [PATCH 4/6 v2] autofs4: factor should_expire() out of autofs4_expire_indirect.

2014-07-16 Thread Ian Kent
On Mon, 2014-07-14 at 10:53 +1000, NeilBrown wrote: > Here is a revised version of this one patch. > This one fixes a problem with refcounts on dentry and adds a comment to > clarify the behaviour of should_expire(). I had some problems with this patch. Looked like it got munged by the email clien

Re: [PATCH 4/6 v2] autofs4: factor should_expire() out of autofs4_expire_indirect.

2014-07-15 Thread Ian Kent
On Tue, 2014-07-15 at 14:05 +1000, NeilBrown wrote: > On Tue, 15 Jul 2014 11:48:33 +0800 Ian Kent wrote: > ... > > So far I've tracked this to something that was introduced between 3.11 > > and 3.12. One change that went into 3.12 was Jeff Laytons' umount > > specific path resolution for umount. I

Re: [PATCH 4/6 v2] autofs4: factor should_expire() out of autofs4_expire_indirect.

2014-07-14 Thread NeilBrown
On Tue, 15 Jul 2014 11:48:33 +0800 Ian Kent wrote: ... > So far I've tracked this to something that was introduced between 3.11 > and 3.12. One change that went into 3.12 was Jeff Laytons' umount > specific path resolution for umount. I've found this is also broken on > recent RHEL-6 kernels and t

Re: [PATCH 4/6 v2] autofs4: factor should_expire() out of autofs4_expire_indirect.

2014-07-14 Thread Ian Kent
On Mon, 2014-07-14 at 10:53 +1000, NeilBrown wrote: > Here is a revised version of this one patch. > This one fixes a problem with refcounts on dentry and adds a comment to > clarify the behaviour of should_expire(). I have some bad news I'm afraid, not about the patches. As I mentioned I'm well

Re: [PATCH 4/6 v2] autofs4: factor should_expire() out of autofs4_expire_indirect.

2014-07-13 Thread NeilBrown
Here is a revised version of this one patch. This one fixes a problem with refcounts on dentry and adds a comment to clarify the behaviour of should_expire(). thanks, NeilBrown From: NeilBrown Date: Tue, 8 Jul 2014 17:14:53 +1000 Subject: [PATCH] autofs4: factor should_expire() out of autofs4_e