Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-29 Thread Serge Semin
On Wed, Jul 29, 2020 at 06:10:24PM +0300, Andy Shevchenko wrote: > On Wed, Jul 29, 2020 at 3:58 PM Serge Semin > wrote: > > On Mon, Jul 27, 2020 at 12:22:28AM +0200, Linus Walleij wrote: > > ... > > > Sorry for a delay with a response to this issue. I had to give it a more > > thorough > >

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-29 Thread Andy Shevchenko
On Wed, Jul 29, 2020 at 3:58 PM Serge Semin wrote: > On Mon, Jul 27, 2020 at 12:22:28AM +0200, Linus Walleij wrote: ... > Sorry for a delay with a response to this issue. I had to give it a more > thorough > thought since the problem is a bit more complex than it seemed originally. As > I >

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-29 Thread Serge Semin
On Mon, Jul 27, 2020 at 12:22:28AM +0200, Linus Walleij wrote: > On Sat, Jul 25, 2020 at 1:03 AM Serge Semin > wrote: > > > According to the DW APB GPIO databook it can be configured to provide > > either a > > combined IRQ line or multiple interrupt signals for each GPIO. It's up to > > the

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 11:18 AM Linus Walleij wrote: > > On Mon, Jul 27, 2020 at 11:50 PM Serge Semin > wrote: > > > It turns out my "mostly" was wrong in this matter. It's 4 out of 17 patches, > > which make the initialization in the same order as mine: > > I'll think about fixing them up to

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-28 Thread Linus Walleij
On Mon, Jul 27, 2020 at 11:50 PM Serge Semin wrote: > It turns out my "mostly" was wrong in this matter. It's 4 out of 17 patches, > which make the initialization in the same order as mine: I'll think about fixing them up to all look the same at some point if noone beats me to it. Sorry for the

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-27 Thread Serge Semin
On Sat, Jul 25, 2020 at 03:12:49PM +0300, Andy Shevchenko wrote: > On Sat, Jul 25, 2020 at 2:03 AM Serge Semin > wrote: > > On Thu, Jul 23, 2020 at 01:03:17PM +0300, Andy Shevchenko wrote: > > > On Thu, Jul 23, 2020 at 04:38:55AM +0300, Serge Semin wrote: ... > > > > + /* This will

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-26 Thread Linus Walleij
On Sat, Jul 25, 2020 at 1:03 AM Serge Semin wrote: > According to the DW APB GPIO databook it can be configured to provide either a > combined IRQ line or multiple interrupt signals for each GPIO. It's up to > the platform which of those signals are connected to an embedded IRQ > controller. So

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-25 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 2:03 AM Serge Semin wrote: > On Thu, Jul 23, 2020 at 01:03:17PM +0300, Andy Shevchenko wrote: > > On Thu, Jul 23, 2020 at 04:38:55AM +0300, Serge Semin wrote: ... > > > 5) Manually select a proper IRQ flow handler directly in the > > > irq_set_type() callback by calling

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-24 Thread Serge Semin
On Thu, Jul 23, 2020 at 05:08:15PM +0300, Andy Shevchenko wrote: > On Thu, Jul 23, 2020 at 04:38:55AM +0300, Serge Semin wrote: > > GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on > > top of a GPIO chip. It's better from maintainability and readability > > point of view to

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-24 Thread Serge Semin
On Thu, Jul 23, 2020 at 01:03:17PM +0300, Andy Shevchenko wrote: > On Thu, Jul 23, 2020 at 04:38:55AM +0300, Serge Semin wrote: > > GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on > > top of a GPIO chip. It's better from maintainability and readability > > point of view to

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-23 Thread Andy Shevchenko
On Thu, Jul 23, 2020 at 04:38:55AM +0300, Serge Semin wrote: > GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on > top of a GPIO chip. It's better from maintainability and readability > point of view to use one instead of supporting a hand-written Generic > IRQ-chip-based

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-23 Thread Linus Walleij
Hi Serge, On Thu, Jul 23, 2020 at 3:39 AM Serge Semin wrote: > GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on > top of a GPIO chip. It's better from maintainability and readability > point of view to use one instead of supporting a hand-written Generic > IRQ-chip-based

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-23 Thread Andy Shevchenko
On Thu, Jul 23, 2020 at 04:38:55AM +0300, Serge Semin wrote: > GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on > top of a GPIO chip. It's better from maintainability and readability > point of view to use one instead of supporting a hand-written Generic > IRQ-chip-based

[PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-22 Thread Serge Semin
GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on top of a GPIO chip. It's better from maintainability and readability point of view to use one instead of supporting a hand-written Generic IRQ-chip-based implementation. Moreover the new implementation won't cause much