Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-04 Thread DaeSeok Youn
Yes, it need to add brace in inner loop. I will send again. Thanks for review. Daeseok Youn 2014-03-04 18:04 GMT+09:00, Dan Carpenter : > On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote: >> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void) >> ci = (ci_t

Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-04 Thread Dan Carpenter
On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote: > @@ -1174,7 +1179,8 @@ cleanup_hdlc(void) > ci = (ci_t *)(netdev_priv(hi->ndev)); > for (j = 0; j < ci->max_port; j++) > for (k = 0; k < MUSYCC_NCHANS; k++) > -

Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-04 Thread Dan Carpenter
On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote: @@ -1174,7 +1179,8 @@ cleanup_hdlc(void) ci = (ci_t *)(netdev_priv(hi-ndev)); for (j = 0; j ci-max_port; j++) for (k = 0; k MUSYCC_NCHANS; k++) -

Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-04 Thread DaeSeok Youn
Yes, it need to add brace in inner loop. I will send again. Thanks for review. Daeseok Youn 2014-03-04 18:04 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote: @@ -1174,7 +1179,8 @@ cleanup_hdlc(void) ci =

[PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-03 Thread Daeseok Youn
checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c

[PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-03 Thread Daeseok Youn
checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/linux.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git