Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API

2016-05-27 Thread Sergey Senozhatsky
On (05/27/16 13:31), Minchan Kim wrote: [..] > > int zcomp_compress(struct zcomp_strm *zstrm, > > - const unsigned char *src, unsigned int *dst_len) > > + const u8 *src, unsigned int *dst_len) > > Nitpick: > > The zcomp doesn't need to depend on implementation(i.e., crypto)

Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API

2016-05-27 Thread Sergey Senozhatsky
On (05/27/16 13:31), Minchan Kim wrote: [..] > > int zcomp_compress(struct zcomp_strm *zstrm, > > - const unsigned char *src, unsigned int *dst_len) > > + const u8 *src, unsigned int *dst_len) > > Nitpick: > > The zcomp doesn't need to depend on implementation(i.e., crypto)

Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API

2016-05-26 Thread Minchan Kim
On Wed, May 25, 2016 at 11:30:03PM +0900, Sergey Senozhatsky wrote: > A cosmetic change: use the same datatypes as crypto API does. > > Signed-off-by: Sergey Senozhatsky > Cc: Minchan Kim > Cc: Joonsoo Kim > --- >

Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API

2016-05-26 Thread Minchan Kim
On Wed, May 25, 2016 at 11:30:03PM +0900, Sergey Senozhatsky wrote: > A cosmetic change: use the same datatypes as crypto API does. > > Signed-off-by: Sergey Senozhatsky > Cc: Minchan Kim > Cc: Joonsoo Kim > --- > drivers/block/zram/zcomp.c| 5 ++--- > drivers/block/zram/zcomp.h| 5

[PATCH 4/7] zram: align zcomp interface to crypto comp API

2016-05-25 Thread Sergey Senozhatsky
A cosmetic change: use the same datatypes as crypto API does. Signed-off-by: Sergey Senozhatsky Cc: Minchan Kim Cc: Joonsoo Kim --- drivers/block/zram/zcomp.c| 5 ++--- drivers/block/zram/zcomp.h| 5 ++---

[PATCH 4/7] zram: align zcomp interface to crypto comp API

2016-05-25 Thread Sergey Senozhatsky
A cosmetic change: use the same datatypes as crypto API does. Signed-off-by: Sergey Senozhatsky Cc: Minchan Kim Cc: Joonsoo Kim --- drivers/block/zram/zcomp.c| 5 ++--- drivers/block/zram/zcomp.h| 5 ++--- drivers/block/zram/zram_drv.c | 2 +- 3 files changed, 5 insertions(+), 7