Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Hi Jisheng, >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mbus"); >> + pxa->mbus_win_regs = devm_ioremap_resource(>dev, res); >> + if (IS_ERR(pxa->mbus_win_regs)) { >> + dev_err(mmc_dev(host->mmc), >> + "failed to obtain MBus windows

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Hi Jisheng, >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mbus"); >> + pxa->mbus_win_regs = devm_ioremap_resource(>dev, res); >> + if (IS_ERR(pxa->mbus_win_regs)) { >> + dev_err(mmc_dev(host->mmc), >> + "failed to obtain MBus windows

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Hi Marcin, On Tue, 6 Oct 2015 03:22:38 +0200 Marcin Wojtas wrote: > When resuming from suspend on Armada 38x SoC MBus windows have to be > re-configured and for that purpose mv_conf_mbus_windows function needed > rework. MBus windows register base address obtaining was moved to >

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Hi Marcin, On Tue, 6 Oct 2015 03:22:38 +0200 Marcin Wojtas wrote: > When resuming from suspend on Armada 38x SoC MBus windows have to be > re-configured and for that purpose mv_conf_mbus_windows function needed > rework. MBus windows register base address obtaining was moved

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Gregory, 2015-10-06 16:51 GMT+02:00 Gregory CLEMENT > + if (of_device_is_compatible(np, "marvell,armada-380-sdhci")) >> + ret = mv_conf_mbus_windows(dev, pxa->mbus_win_regs, >> +mv_mbus_dram_info()); > > I would find it cleaner to not rely

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Hi Marcin, On mar., oct. 06 2015, Marcin Wojtas wrote: > When resuming from suspend on Armada 38x SoC MBus windows have to be > re-configured and for that purpose mv_conf_mbus_windows function needed > rework. MBus windows register base address obtaining was moved to > armada_38x_quirks

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Gregory, 2015-10-06 16:51 GMT+02:00 Gregory CLEMENT > + if (of_device_is_compatible(np, "marvell,armada-380-sdhci")) >> + ret = mv_conf_mbus_windows(dev, pxa->mbus_win_regs, >> +mv_mbus_dram_info()); > > I would find it cleaner to not rely

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Hi Marcin, On mar., oct. 06 2015, Marcin Wojtas wrote: > When resuming from suspend on Armada 38x SoC MBus windows have to be > re-configured and for that purpose mv_conf_mbus_windows function needed > rework. MBus windows register base address obtaining was moved to >

[PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

When resuming from suspend on Armada 38x SoC MBus windows have to be re-configured and for that purpose mv_conf_mbus_windows function needed rework. MBus windows register base address obtaining was moved to armada_38x_quirks function in order to be kept in pxa global structure, because it is used

[PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

When resuming from suspend on Armada 38x SoC MBus windows have to be re-configured and for that purpose mv_conf_mbus_windows function needed rework. MBus windows register base address obtaining was moved to armada_38x_quirks function in order to be kept in pxa global structure, because it is used