2013/3/20 Peter Zijlstra :
> On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
>
>> > Right, so I'm not so taken with this one. The whole load stuff really
>> > is a balance heuristic that's part of move_tasks(), move_one_task()
>> > really doesn't care about that.
>> >
>> > So why did you
On Wed, 2013-03-20 at 12:16 +0100, Peter Zijlstra wrote:
> > If your recommandation is to move up can_mirate_task() above
> > load evaluation code, yes, I can, and will do that. :)
>
> I would actually propose
... to move the throttled test into can_migrate_task().
(damn evo crashed on me...
On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
> > Right, so I'm not so taken with this one. The whole load stuff really
> > is a balance heuristic that's part of move_tasks(), move_one_task()
> > really doesn't care about that.
> >
> > So why did you include it? Purely so you didn't
On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
> > Right, so I'm not so taken with this one. The whole load stuff really
> > is a balance heuristic that's part of move_tasks(), move_one_task()
> > really doesn't care about that.
> >
> > So why did you include it? Purely so you didn't have
On Tue, Mar 19, 2013 at 03:30:15PM +0100, Peter Zijlstra wrote:
> On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> > Some validation for task moving is performed in move_tasks() and
> > move_one_task(). We can move these code to can_migrate_task()
> > which is already exist for this
On Tue, Mar 19, 2013 at 03:30:15PM +0100, Peter Zijlstra wrote:
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
Some validation for task moving is performed in move_tasks() and
move_one_task(). We can move these code to can_migrate_task()
which is already exist for this purpose.
On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
Right, so I'm not so taken with this one. The whole load stuff really
is a balance heuristic that's part of move_tasks(), move_one_task()
really doesn't care about that.
So why did you include it? Purely so you didn't have to
On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
Right, so I'm not so taken with this one. The whole load stuff really
is a balance heuristic that's part of move_tasks(), move_one_task()
really doesn't care about that.
So why did you include it? Purely so you didn't have to
On Wed, 2013-03-20 at 12:16 +0100, Peter Zijlstra wrote:
If your recommandation is to move up can_mirate_task() above
load evaluation code, yes, I can, and will do that. :)
I would actually propose
... to move the throttled test into can_migrate_task().
(damn evo crashed on me...
2013/3/20 Peter Zijlstra pet...@infradead.org:
On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
Right, so I'm not so taken with this one. The whole load stuff really
is a balance heuristic that's part of move_tasks(), move_one_task()
really doesn't care about that.
So why did you
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> Some validation for task moving is performed in move_tasks() and
> move_one_task(). We can move these code to can_migrate_task()
> which is already exist for this purpose.
> @@ -4011,18 +4027,7 @@ static int move_tasks(struct lb_env *env)
>
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
Some validation for task moving is performed in move_tasks() and
move_one_task(). We can move these code to can_migrate_task()
which is already exist for this purpose.
@@ -4011,18 +4027,7 @@ static int move_tasks(struct lb_env *env)
Some validation for task moving is performed in move_tasks() and
move_one_task(). We can move these code to can_migrate_task()
which is already exist for this purpose.
Signed-off-by: Joonsoo Kim
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 97498f4..849bc8e 100644
---
Some validation for task moving is performed in move_tasks() and
move_one_task(). We can move these code to can_migrate_task()
which is already exist for this purpose.
Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 97498f4..849bc8e
14 matches
Mail list logo
