Re: [PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-15 Thread Arnd Bergmann
On Thursday 14 February 2013, Tony Lindgren wrote: > I left it out intentionally as these are private to mach-omap2, > and I'd like to simplify the indirect includes there further. > So I'd rather just remove the duplicate soc.h from drm.c. > > If people really think this should be applied, I

Re: [PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-15 Thread Arnd Bergmann
On Thursday 14 February 2013, Tony Lindgren wrote: I left it out intentionally as these are private to mach-omap2, and I'd like to simplify the indirect includes there further. So I'd rather just remove the duplicate soc.h from drm.c. If people really think this should be applied, I have no

Re: [PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-14 Thread Arnd Bergmann
On Thursday 14 February 2013, Tony Lindgren wrote: > I left it out intentionally as these are private to mach-omap2, > and I'd like to simplify the indirect includes there further. > So I'd rather just remove the duplicate soc.h from drm.c. > > If people really think this should be applied, I

Re: [PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-14 Thread Tony Lindgren
* Arnd Bergmann [130214 14:51]: > Commit e4c060db "ARM: OMAP: Split plat/cpu.h into local soc.h for > mach-omap1 and mach-omap2" moved the bulk of "plat/cpu.h" into "cpu.h" > but did not add an include guard for the new file that was present > in the old one. There are cases where the file is

[PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-14 Thread Arnd Bergmann
Commit e4c060db "ARM: OMAP: Split plat/cpu.h into local soc.h for mach-omap1 and mach-omap2" moved the bulk of "plat/cpu.h" into "cpu.h" but did not add an include guard for the new file that was present in the old one. There are cases where the file is indeed included multiple times, probably by

[PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-14 Thread Arnd Bergmann
Commit e4c060db ARM: OMAP: Split plat/cpu.h into local soc.h for mach-omap1 and mach-omap2 moved the bulk of plat/cpu.h into cpu.h but did not add an include guard for the new file that was present in the old one. There are cases where the file is indeed included multiple times, probably by

Re: [PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-14 Thread Tony Lindgren
* Arnd Bergmann a...@arndb.de [130214 14:51]: Commit e4c060db ARM: OMAP: Split plat/cpu.h into local soc.h for mach-omap1 and mach-omap2 moved the bulk of plat/cpu.h into cpu.h but did not add an include guard for the new file that was present in the old one. There are cases where the file is

Re: [PATCH 4/9] ARM: omap: add include guard for soc.h

2013-02-14 Thread Arnd Bergmann
On Thursday 14 February 2013, Tony Lindgren wrote: I left it out intentionally as these are private to mach-omap2, and I'd like to simplify the indirect includes there further. So I'd rather just remove the duplicate soc.h from drm.c. If people really think this should be applied, I have no