Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-20 Thread Dirk Gouders
Christoph Hellwig writes: > On Wed, Jul 18, 2018 at 12:06:26AM -0700, Randy Dunlap wrote: >> All $ARCH look equivalent except for microblaze and nios2. >> For those, the config SWAP in init/Kconfig (line 221) comes before (and >> hence takes precedence) over arch/$(SRCARCH)/Kconfig settings,

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-20 Thread Dirk Gouders
Christoph Hellwig writes: > On Wed, Jul 18, 2018 at 12:06:26AM -0700, Randy Dunlap wrote: >> All $ARCH look equivalent except for microblaze and nios2. >> For those, the config SWAP in init/Kconfig (line 221) comes before (and >> hence takes precedence) over arch/$(SRCARCH)/Kconfig settings,

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-19 Thread Christoph Hellwig
On Wed, Jul 18, 2018 at 12:06:26AM -0700, Randy Dunlap wrote: > All $ARCH look equivalent except for microblaze and nios2. > For those, the config SWAP in init/Kconfig (line 221) comes before (and > hence takes precedence) over arch/$(SRCARCH)/Kconfig settings, which is > def_bool n for both

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-19 Thread Christoph Hellwig
On Wed, Jul 18, 2018 at 12:06:26AM -0700, Randy Dunlap wrote: > All $ARCH look equivalent except for microblaze and nios2. > For those, the config SWAP in init/Kconfig (line 221) comes before (and > hence takes precedence) over arch/$(SRCARCH)/Kconfig settings, which is > def_bool n for both

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-18 Thread Randy Dunlap
On 07/11/2018 05:21 AM, Masahiro Yamada wrote: > 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of >>

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-18 Thread Randy Dunlap
On 07/11/2018 05:21 AM, Masahiro Yamada wrote: > 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of >>

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Christoph Hellwig
On Mon, Jul 16, 2018 at 11:42:54PM -0700, Randy Dunlap wrote: > Well, there are 3 $ARCH-es that have an arch/$ARCH/mm/Kconfig file: > arm, sh, and unicore32. > > We can either merge those into arch/$ARCH/Kconfig or we can source > arch/$ARCH/mm/Kconfig for all $ARCH (where most of these files

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Christoph Hellwig
On Mon, Jul 16, 2018 at 11:42:54PM -0700, Randy Dunlap wrote: > Well, there are 3 $ARCH-es that have an arch/$ARCH/mm/Kconfig file: > arm, sh, and unicore32. > > We can either merge those into arch/$ARCH/Kconfig or we can source > arch/$ARCH/mm/Kconfig for all $ARCH (where most of these files

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Christoph Hellwig
On Mon, Jul 16, 2018 at 11:33:38PM -0700, Randy Dunlap wrote: > Thanks for noticing that. > > I have tested all $ARCH (except um) with "allmodconfig" and so far, arch/sh/ > is the only one that has a problem. I'm a little busy right now, I'll got back to fix sh and retest in a few days

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Christoph Hellwig
On Mon, Jul 16, 2018 at 11:33:38PM -0700, Randy Dunlap wrote: > Thanks for noticing that. > > I have tested all $ARCH (except um) with "allmodconfig" and so far, arch/sh/ > is the only one that has a problem. I'm a little busy right now, I'll got back to fix sh and retest in a few days

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/16/2018 11:44 PM, Randy Dunlap wrote: > On 07/16/2018 11:42 PM, Randy Dunlap wrote: >> On 07/16/2018 11:33 PM, Randy Dunlap wrote: >>> On 07/11/2018 05:21 AM, Masahiro Yamada wrote: 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : > Instead of duplicating the source statements in every

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/16/2018 11:44 PM, Randy Dunlap wrote: > On 07/16/2018 11:42 PM, Randy Dunlap wrote: >> On 07/16/2018 11:33 PM, Randy Dunlap wrote: >>> On 07/11/2018 05:21 AM, Masahiro Yamada wrote: 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : > Instead of duplicating the source statements in every

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/16/2018 11:42 PM, Randy Dunlap wrote: > On 07/16/2018 11:33 PM, Randy Dunlap wrote: >> On 07/11/2018 05:21 AM, Masahiro Yamada wrote: >>> 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : Instead of duplicating the source statements in every architecture just do it once in the toplevel

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/16/2018 11:42 PM, Randy Dunlap wrote: > On 07/16/2018 11:33 PM, Randy Dunlap wrote: >> On 07/11/2018 05:21 AM, Masahiro Yamada wrote: >>> 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : Instead of duplicating the source statements in every architecture just do it once in the toplevel

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/16/2018 11:33 PM, Randy Dunlap wrote: > On 07/11/2018 05:21 AM, Masahiro Yamada wrote: >> 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : >>> Instead of duplicating the source statements in every architecture just >>> do it once in the toplevel Kconfig file. >>> >>> Note that with this the

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/16/2018 11:33 PM, Randy Dunlap wrote: > On 07/11/2018 05:21 AM, Masahiro Yamada wrote: >> 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : >>> Instead of duplicating the source statements in every architecture just >>> do it once in the toplevel Kconfig file. >>> >>> Note that with this the

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/11/2018 05:21 AM, Masahiro Yamada wrote: > 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of >>

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-17 Thread Randy Dunlap
On 07/11/2018 05:21 AM, Masahiro Yamada wrote: > 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of >>

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-11 Thread Masahiro Yamada
2018-07-09 0:19 GMT+09:00 Christoph Hellwig : > Instead of duplicating the source statements in every architecture just > do it once in the toplevel Kconfig file. > > Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of > the top-level Kconfig into arch/Kconfig so that don't

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-11 Thread Masahiro Yamada
2018-07-09 0:19 GMT+09:00 Christoph Hellwig : > Instead of duplicating the source statements in every architecture just > do it once in the toplevel Kconfig file. > > Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of > the top-level Kconfig into arch/Kconfig so that don't

[PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-08 Thread Christoph Hellwig
Instead of duplicating the source statements in every architecture just do it once in the toplevel Kconfig file. Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of the top-level Kconfig into arch/Kconfig so that don't violate ordering constraits while keeping a sensible menu

[PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-08 Thread Christoph Hellwig
Instead of duplicating the source statements in every architecture just do it once in the toplevel Kconfig file. Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of the top-level Kconfig into arch/Kconfig so that don't violate ordering constraits while keeping a sensible menu