Re: [PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-28 Thread Arnd Bergmann
On Thursday 28 January 2016 17:53:43 Arnd Bergmann wrote: > > Makes sense. I looked at the ftmac100 driver, which is another driver > for the same hardware, and it's also missing barriers. We should > probably add them for both then. > Nevermind. That one has write barriers, but no read

Re: [PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-28 Thread Arnd Bergmann
On Thursday 28 January 2016 12:36:19 David Laight wrote: > From: Arnd Bergmann > > Sent: 27 January 2016 14:05 > > The moxart ethernet driver confuses coherent DMA buffers with > > MMIO registers. > > > > moxart_ether.c: In function 'moxart_mac_setup_desc_ring': > > moxart_ether.c:146:428: error:

RE: [PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-28 Thread David Laight
From: Arnd Bergmann > Sent: 27 January 2016 14:05 > The moxart ethernet driver confuses coherent DMA buffers with > MMIO registers. > > moxart_ether.c: In function 'moxart_mac_setup_desc_ring': > moxart_ether.c:146:428: error: passing argument 1 of '__fswab32' makes > integer from pointer

Re: [PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-28 Thread Arnd Bergmann
On Thursday 28 January 2016 12:36:19 David Laight wrote: > From: Arnd Bergmann > > Sent: 27 January 2016 14:05 > > The moxart ethernet driver confuses coherent DMA buffers with > > MMIO registers. > > > > moxart_ether.c: In function 'moxart_mac_setup_desc_ring': > > moxart_ether.c:146:428: error:

Re: [PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-28 Thread Arnd Bergmann
On Thursday 28 January 2016 17:53:43 Arnd Bergmann wrote: > > Makes sense. I looked at the ftmac100 driver, which is another driver > for the same hardware, and it's also missing barriers. We should > probably add them for both then. > Nevermind. That one has write barriers, but no read

RE: [PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-28 Thread David Laight
From: Arnd Bergmann > Sent: 27 January 2016 14:05 > The moxart ethernet driver confuses coherent DMA buffers with > MMIO registers. > > moxart_ether.c: In function 'moxart_mac_setup_desc_ring': > moxart_ether.c:146:428: error: passing argument 1 of '__fswab32' makes > integer from pointer

[PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-27 Thread Arnd Bergmann
The moxart ethernet driver confuses coherent DMA buffers with MMIO registers. moxart_ether.c: In function 'moxart_mac_setup_desc_ring': moxart_ether.c:146:428: error: passing argument 1 of '__fswab32' makes integer from pointer without a cast [-Werror=int-conversion] moxart_ether.c:74:39:

[PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-27 Thread Arnd Bergmann
The moxart ethernet driver confuses coherent DMA buffers with MMIO registers. moxart_ether.c: In function 'moxart_mac_setup_desc_ring': moxart_ether.c:146:428: error: passing argument 1 of '__fswab32' makes integer from pointer without a cast [-Werror=int-conversion] moxart_ether.c:74:39: