Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-20 Thread Mark Rutland
On Fri, Jul 17, 2015 at 09:17:47PM +0100, Andi Kleen wrote: > > As with my earlier comments, I don't think these can be grouped with > > events (not even from the same PMU given their free-running nature). > > Mark, we already went through this last time. There is nothing > stopping handling free

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-20 Thread Mark Rutland
On Fri, Jul 17, 2015 at 09:17:47PM +0100, Andi Kleen wrote: As with my earlier comments, I don't think these can be grouped with events (not even from the same PMU given their free-running nature). Mark, we already went through this last time. There is nothing stopping handling free

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Andi Kleen
> As with my earlier comments, I don't think these can be grouped with > events (not even from the same PMU given their free-running nature). Mark, we already went through this last time. There is nothing stopping handling free running counters as part of other groups. A perf event logically has

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Stephane Eranian
Hi, On Fri, Jul 17, 2015 at 5:55 AM, Peter Zijlstra wrote: > On Fri, Jul 17, 2015 at 01:21:06PM +0100, Mark Rutland wrote: >> >> As with my earlier comments, I don't think these can be grouped with >> events (not even from the same PMU given their free-running nature). >> >> They're CPU-affine,

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 01:21:06PM +0100, Mark Rutland wrote: > > As with my earlier comments, I don't think these can be grouped with > events (not even from the same PMU given their free-running nature). > > They're CPU-affine, so you can associate them with work done on that > CPU. Just

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Mark Rutland
On Thu, Jul 16, 2015 at 09:33:46PM +0100, kan.li...@intel.com wrote: > From: Kan Liang > > This patch special case per-cpu core_misc PMU events and allow them to > be part of any hardware/software group for system-wide monitoring. > An useful example would be to include the ASTATE/MSTATE event

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Mark Rutland
On Thu, Jul 16, 2015 at 09:33:46PM +0100, kan.li...@intel.com wrote: From: Kan Liang kan.li...@intel.com This patch special case per-cpu core_misc PMU events and allow them to be part of any hardware/software group for system-wide monitoring. An useful example would be to include the

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 01:21:06PM +0100, Mark Rutland wrote: As with my earlier comments, I don't think these can be grouped with events (not even from the same PMU given their free-running nature). They're CPU-affine, so you can associate them with work done on that CPU. Just record the

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Stephane Eranian
Hi, On Fri, Jul 17, 2015 at 5:55 AM, Peter Zijlstra pet...@infradead.org wrote: On Fri, Jul 17, 2015 at 01:21:06PM +0100, Mark Rutland wrote: As with my earlier comments, I don't think these can be grouped with events (not even from the same PMU given their free-running nature). They're

Re: [PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-17 Thread Andi Kleen
As with my earlier comments, I don't think these can be grouped with events (not even from the same PMU given their free-running nature). Mark, we already went through this last time. There is nothing stopping handling free running counters as part of other groups. A perf event logically has a

[PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-16 Thread kan . liang
From: Kan Liang This patch special case per-cpu core_misc PMU events and allow them to be part of any hardware/software group for system-wide monitoring. An useful example would be to include the ASTATE/MSTATE event in a sampling group. This can be used to calculate the frequency during each

[PATCH 4/9] perf/x86: special case per-cpu core misc PMU events

2015-07-16 Thread kan . liang
From: Kan Liang kan.li...@intel.com This patch special case per-cpu core_misc PMU events and allow them to be part of any hardware/software group for system-wide monitoring. An useful example would be to include the ASTATE/MSTATE event in a sampling group. This can be used to calculate the