Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-20 Thread Peng Tao
On 11/21/2013 12:27 AM, Greg Kroah-Hartman wrote: On Wed, Nov 20, 2013 at 05:26:57PM +0800, Peng Tao wrote: On Wed, Nov 20, 2013 at 2:37 AM, Greg Kroah-Hartman wrote: On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: From: Amir Shehata The core of the issue is that the selftest

Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-20 Thread Greg Kroah-Hartman
On Wed, Nov 20, 2013 at 05:26:57PM +0800, Peng Tao wrote: > On Wed, Nov 20, 2013 at 2:37 AM, Greg Kroah-Hartman > wrote: > > On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: > >> From: Amir Shehata > >> > >> The core of the issue is that the selftest module doesn't sanitize its > >> own

Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-20 Thread Peng Tao
On Wed, Nov 20, 2013 at 2:37 AM, Greg Kroah-Hartman wrote: > On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: >> From: Amir Shehata >> >> The core of the issue is that the selftest module doesn't sanitize its >> own API, but it depends on lst utility to do such checks. As a result >>

Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-20 Thread Peng Tao
On Wed, Nov 20, 2013 at 2:37 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: From: Amir Shehata amir.sheh...@intel.com The core of the issue is that the selftest module doesn't sanitize its own API, but it depends on lst

Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-20 Thread Greg Kroah-Hartman
On Wed, Nov 20, 2013 at 05:26:57PM +0800, Peng Tao wrote: On Wed, Nov 20, 2013 at 2:37 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: From: Amir Shehata amir.sheh...@intel.com The core of the issue is that the selftest

Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-20 Thread Peng Tao
On 11/21/2013 12:27 AM, Greg Kroah-Hartman wrote: On Wed, Nov 20, 2013 at 05:26:57PM +0800, Peng Tao wrote: On Wed, Nov 20, 2013 at 2:37 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: From: Amir Shehata amir.sheh...@intel.com

Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-19 Thread Greg Kroah-Hartman
On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: > From: Amir Shehata > > The core of the issue is that the selftest module doesn't sanitize its > own API, but it depends on lst utility to do such checks. As a result > this issue manifests itself in this particular LU through an assert

[PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-19 Thread Peng Tao
From: Amir Shehata The core of the issue is that the selftest module doesn't sanitize its own API, but it depends on lst utility to do such checks. As a result this issue manifests itself in this particular LU through an assert on an empty group. If the NID is misspelled then an empty group is

[PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-19 Thread Peng Tao
From: Amir Shehata amir.sheh...@intel.com The core of the issue is that the selftest module doesn't sanitize its own API, but it depends on lst utility to do such checks. As a result this issue manifests itself in this particular LU through an assert on an empty group. If the NID is misspelled

Re: [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module

2013-11-19 Thread Greg Kroah-Hartman
On Tue, Nov 19, 2013 at 09:23:43PM +0800, Peng Tao wrote: From: Amir Shehata amir.sheh...@intel.com The core of the issue is that the selftest module doesn't sanitize its own API, but it depends on lst utility to do such checks. As a result this issue manifests itself in this particular LU