Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Greg Kroah-Hartman
On Thu, Jan 19, 2017 at 02:21:47PM +0100, Ingo Molnar wrote: > > * Greg Kroah-Hartman wrote: > > > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > > > > > > > > > On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > > > > > > > * Prarit Bhargava

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Greg Kroah-Hartman
On Thu, Jan 19, 2017 at 02:21:47PM +0100, Ingo Molnar wrote: > > * Greg Kroah-Hartman wrote: > > > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > > > > > > > > > On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > > > > > > > * Prarit Bhargava wrote: > > > > > > > >> 4.9 is

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Greg Kroah-Hartman
On Thu, Jan 19, 2017 at 07:05:45AM -0500, Prarit Bhargava wrote: > > > On 01/19/2017 06:49 AM, Greg Kroah-Hartman wrote: > > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > >> > >> > >> On 01/18/2017 05:25 PM, Ingo Molnar wrote: > >>> > >>> * Prarit Bhargava

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Greg Kroah-Hartman
On Thu, Jan 19, 2017 at 07:05:45AM -0500, Prarit Bhargava wrote: > > > On 01/19/2017 06:49 AM, Greg Kroah-Hartman wrote: > > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > >> > >> > >> On 01/18/2017 05:25 PM, Ingo Molnar wrote: > >>> > >>> * Prarit Bhargava wrote: > >>> >

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Ingo Molnar
* Greg Kroah-Hartman wrote: > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > > > > > > On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > > > > > * Prarit Bhargava wrote: > > > > > >> 4.9 is broken and requires additional

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Ingo Molnar
* Greg Kroah-Hartman wrote: > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > > > > > > On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > > > > > * Prarit Bhargava wrote: > > > > > >> 4.9 is broken and requires additional patches beyond this patch. > > >> Applying this >

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Prarit Bhargava
On 01/19/2017 06:49 AM, Greg Kroah-Hartman wrote: > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: >> >> >> On 01/18/2017 05:25 PM, Ingo Molnar wrote: >>> >>> * Prarit Bhargava wrote: >>> 4.9 is broken and requires additional patches beyond this patch.

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Prarit Bhargava
On 01/19/2017 06:49 AM, Greg Kroah-Hartman wrote: > On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: >> >> >> On 01/18/2017 05:25 PM, Ingo Molnar wrote: >>> >>> * Prarit Bhargava wrote: >>> 4.9 is broken and requires additional patches beyond this patch. Applying

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Prarit Bhargava
On 01/18/2017 12:20 PM, Greg Kroah-Hartman wrote: > On Wed, Jan 18, 2017 at 11:55:58AM -0500, Prarit Bhargava wrote: >> >> >> On 01/18/2017 11:33 AM, Greg Kroah-Hartman wrote: >>> On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: On 01/18/2017 05:45 AM, Greg

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Prarit Bhargava
On 01/18/2017 12:20 PM, Greg Kroah-Hartman wrote: > On Wed, Jan 18, 2017 at 11:55:58AM -0500, Prarit Bhargava wrote: >> >> >> On 01/18/2017 11:33 AM, Greg Kroah-Hartman wrote: >>> On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: On 01/18/2017 05:45 AM, Greg

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Greg Kroah-Hartman
On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > > > On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > > > * Prarit Bhargava wrote: > > > >> 4.9 is broken and requires additional patches beyond this patch. Applying > >> this > >> patch to 4.9 stable

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Greg Kroah-Hartman
On Thu, Jan 19, 2017 at 05:32:46AM -0500, Prarit Bhargava wrote: > > > On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > > > * Prarit Bhargava wrote: > > > >> 4.9 is broken and requires additional patches beyond this patch. Applying > >> this > >> patch to 4.9 stable without those additional

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Prarit Bhargava
On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > * Prarit Bhargava wrote: > >> 4.9 is broken and requires additional patches beyond this patch. Applying >> this >> patch to 4.9 stable without those additional fixes will result in kernel >> panics >> on some Haswell

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-19 Thread Prarit Bhargava
On 01/18/2017 05:25 PM, Ingo Molnar wrote: > > * Prarit Bhargava wrote: > >> 4.9 is broken and requires additional patches beyond this patch. Applying >> this >> patch to 4.9 stable without those additional fixes will result in kernel >> panics >> on some Haswell systems that boot on

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Ingo Molnar
* Prarit Bhargava wrote: > 4.9 is broken and requires additional patches beyond this patch. Applying > this > patch to 4.9 stable without those additional fixes will result in kernel > panics > on some Haswell systems that boot on random cores. Could you list the

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Ingo Molnar
* Prarit Bhargava wrote: > 4.9 is broken and requires additional patches beyond this patch. Applying > this > patch to 4.9 stable without those additional fixes will result in kernel > panics > on some Haswell systems that boot on random cores. Could you list the patches that are

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Greg Kroah-Hartman
On Wed, Jan 18, 2017 at 11:55:58AM -0500, Prarit Bhargava wrote: > > > On 01/18/2017 11:33 AM, Greg Kroah-Hartman wrote: > > On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: > >> > >> > >> On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: > >>> 4.9-stable review patch. If anyone

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Greg Kroah-Hartman
On Wed, Jan 18, 2017 at 11:55:58AM -0500, Prarit Bhargava wrote: > > > On 01/18/2017 11:33 AM, Greg Kroah-Hartman wrote: > > On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: > >> > >> > >> On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: > >>> 4.9-stable review patch. If anyone

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Prarit Bhargava
On 01/18/2017 11:33 AM, Greg Kroah-Hartman wrote: > On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: >> >> >> On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: >>> 4.9-stable review patch. If anyone has any objections, please let me know. >>> >> >> Nack. >> >> The value of

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Prarit Bhargava
On 01/18/2017 11:33 AM, Greg Kroah-Hartman wrote: > On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: >> >> >> On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: >>> 4.9-stable review patch. If anyone has any objections, please let me know. >>> >> >> Nack. >> >> The value of

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Greg Kroah-Hartman
On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: > > > On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > > > Nack. > > The value of boot_cpu_data.logical_proc_id may be uninitialized and set to

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Greg Kroah-Hartman
On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote: > > > On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > > > Nack. > > The value of boot_cpu_data.logical_proc_id may be uninitialized and set to

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Prarit Bhargava
On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: > 4.9-stable review patch. If anyone has any objections, please let me know. > Nack. The value of boot_cpu_data.logical_proc_id may be uninitialized and set to default -1 on systems that pick a random core as boot cpu. This was inadvertently

Re: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Prarit Bhargava
On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote: > 4.9-stable review patch. If anyone has any objections, please let me know. > Nack. The value of boot_cpu_data.logical_proc_id may be uninitialized and set to default -1 on systems that pick a random core as boot cpu. This was inadvertently

[PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Prarit Bhargava commit 6d6daa20945f3f598e56e18d1f926c08754f5801 upstream. hswep_uncore_cpu_init() uses a hardcoded physical package id 0 for the boot cpu. This works as long

[PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code

2017-01-18 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Prarit Bhargava commit 6d6daa20945f3f598e56e18d1f926c08754f5801 upstream. hswep_uncore_cpu_init() uses a hardcoded physical package id 0 for the boot cpu. This works as long as the boot CPU is