Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-17 Thread Greg Kroah-Hartman
On Tue, Apr 16, 2019 at 11:41:53PM -0700, Nathan Chancellor wrote: > On Wed, Apr 17, 2019 at 08:15:08AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 16, 2019 at 09:47:51AM -0700, Nathan Chancellor wrote: > > > On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > > > > On Mon,

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-17 Thread Nathan Chancellor
On Wed, Apr 17, 2019 at 08:15:08AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 16, 2019 at 09:47:51AM -0700, Nathan Chancellor wrote: > > On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > > > On Mon,

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-17 Thread Greg Kroah-Hartman
On Tue, Apr 16, 2019 at 09:47:51AM -0700, Nathan Chancellor wrote: > On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > > > From:

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Nathan Chancellor
On Tue, Apr 16, 2019 at 10:13:40AM +0100, Will Deacon wrote: > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > > From: Will Deacon > > [...] > > > > @@ -53,29 +53,29 @@ > > > static inline int > > >

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Nathan Chancellor
On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > > From: Will Deacon > > > > > > commit 045afc24124d80c6998d9c770844c67912083506

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Will Deacon
On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > From: Will Deacon [...] > > @@ -53,29 +53,29 @@ > > static inline int > > arch_futex_atomic_op_inuser(int op, int oparg, int *oval, u32 __user > >

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Greg Kroah-Hartman
On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > From: Will Deacon > > > > commit 045afc24124d80c6998d9c770844c67912083506 upstream. > > > > Rather embarrassingly, our futex() FUTEX_WAKE_OP

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-15 Thread Nathan Chancellor
On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > From: Will Deacon > > commit 045afc24124d80c6998d9c770844c67912083506 upstream. > > Rather embarrassingly, our futex() FUTEX_WAKE_OP implementation doesn't > explicitly set the return value on the non-faulting path and

[PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-15 Thread Greg Kroah-Hartman
From: Will Deacon commit 045afc24124d80c6998d9c770844c67912083506 upstream. Rather embarrassingly, our futex() FUTEX_WAKE_OP implementation doesn't explicitly set the return value on the non-faulting path and instead leaves it holding the result of the underlying atomic operation. This means