Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Jason Gunthorpe
On Mon, Nov 19, 2012 at 03:00:06PM -0800, Greg KH wrote: > I could just leave things alone, with CONFIG_HOTPLUG always enabled, but > then people will continue to blindly use the __dev* markings, getting it > wrong at times, but never realizing that they don't do anything anymore. Well, I was

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Greg KH
On Mon, Nov 19, 2012 at 03:48:45PM -0700, Jason Gunthorpe wrote: > On Mon, Nov 19, 2012 at 02:06:32PM -0800, Greg KH wrote: > > > > 5k isn't a lot, but in the context of 'I have to figure out how to > > > trim ~1MB off the 3.6 kernel to run it in our smallest hardware' it is > > > the wrong

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Jason Gunthorpe
On Mon, Nov 19, 2012 at 02:06:32PM -0800, Greg KH wrote: > > 5k isn't a lot, but in the context of 'I have to figure out how to > > trim ~1MB off the 3.6 kernel to run it in our smallest hardware' it is > > the wrong direction :( > > It is only 0.138% in the "wrong" direction. Seriously, that's

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Greg KH
On Mon, Nov 19, 2012 at 02:49:22PM -0700, Jason Gunthorpe wrote: > On Mon, Nov 19, 2012 at 12:19:38PM -0800, Greg KH wrote: > > On Mon, Nov 19, 2012 at 01:09:21PM -0700, Jason Gunthorpe wrote: > > > On Mon, Nov 19, 2012 at 01:25:56PM -0500, Bill Pemberton wrote: > > > > CONFIG_HOTPLUG is going

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Jason Gunthorpe
On Mon, Nov 19, 2012 at 12:19:38PM -0800, Greg KH wrote: > On Mon, Nov 19, 2012 at 01:09:21PM -0700, Jason Gunthorpe wrote: > > On Mon, Nov 19, 2012 at 01:25:56PM -0500, Bill Pemberton wrote: > > > CONFIG_HOTPLUG is going away as an option so __devexit is no > > > longer needed. > > > > I'm sad

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Jason Gunthorpe
On Mon, Nov 19, 2012 at 12:19:38PM -0800, Greg KH wrote: On Mon, Nov 19, 2012 at 01:09:21PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 01:25:56PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. I'm sad to hear this,

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Greg KH
On Mon, Nov 19, 2012 at 02:49:22PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 12:19:38PM -0800, Greg KH wrote: On Mon, Nov 19, 2012 at 01:09:21PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 01:25:56PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Jason Gunthorpe
On Mon, Nov 19, 2012 at 02:06:32PM -0800, Greg KH wrote: 5k isn't a lot, but in the context of 'I have to figure out how to trim ~1MB off the 3.6 kernel to run it in our smallest hardware' it is the wrong direction :( It is only 0.138% in the wrong direction. Seriously, that's a very

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Greg KH
On Mon, Nov 19, 2012 at 03:48:45PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 02:06:32PM -0800, Greg KH wrote: 5k isn't a lot, but in the context of 'I have to figure out how to trim ~1MB off the 3.6 kernel to run it in our smallest hardware' it is the wrong direction :(

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Jason Gunthorpe
On Mon, Nov 19, 2012 at 03:00:06PM -0800, Greg KH wrote: I could just leave things alone, with CONFIG_HOTPLUG always enabled, but then people will continue to blindly use the __dev* markings, getting it wrong at times, but never realizing that they don't do anything anymore. Well, I was