Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-28 Thread Namhyung Kim
Hi Arnaldo and Jiri, On Thu, Sep 27, 2018 at 06:01:58PM +0200, Jiri Olsa wrote: > On Wed, Sep 26, 2018 at 08:23:17AM +0200, Jiri Olsa wrote: > > SNIP > > > > I agree with Namhyung, with a slight difference: perhaps we should set > > > perf_event_attr.mmap on one of the events of the per-cpu

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-28 Thread Namhyung Kim
Hi Arnaldo and Jiri, On Thu, Sep 27, 2018 at 06:01:58PM +0200, Jiri Olsa wrote: > On Wed, Sep 26, 2018 at 08:23:17AM +0200, Jiri Olsa wrote: > > SNIP > > > > I agree with Namhyung, with a slight difference: perhaps we should set > > > perf_event_attr.mmap on one of the events of the per-cpu

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-27 Thread Jiri Olsa
On Wed, Sep 26, 2018 at 08:23:17AM +0200, Jiri Olsa wrote: SNIP > > I agree with Namhyung, with a slight difference: perhaps we should set > > perf_event_attr.mmap on one of the events of the per-cpu mmap, that way > > we don't need that dummy event, right? > > currently it's all based on

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-27 Thread Jiri Olsa
On Wed, Sep 26, 2018 at 08:23:17AM +0200, Jiri Olsa wrote: SNIP > > I agree with Namhyung, with a slight difference: perhaps we should set > > perf_event_attr.mmap on one of the events of the per-cpu mmap, that way > > we don't need that dummy event, right? > > currently it's all based on

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-26 Thread Jiri Olsa
On Mon, Sep 24, 2018 at 11:22:54AM -0300, Arnaldo Carvalho de Melo wrote: > Em Sun, Sep 23, 2018 at 09:44:32PM +0200, Jiri Olsa escreveu: > > On Mon, Sep 17, 2018 at 08:40:48PM +0900, Namhyung Kim wrote: > > > On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > > > > Currently we assign

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-26 Thread Jiri Olsa
On Mon, Sep 24, 2018 at 11:22:54AM -0300, Arnaldo Carvalho de Melo wrote: > Em Sun, Sep 23, 2018 at 09:44:32PM +0200, Jiri Olsa escreveu: > > On Mon, Sep 17, 2018 at 08:40:48PM +0900, Namhyung Kim wrote: > > > On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > > > > Currently we assign

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-24 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 23, 2018 at 09:44:32PM +0200, Jiri Olsa escreveu: > On Mon, Sep 17, 2018 at 08:40:48PM +0900, Namhyung Kim wrote: > > On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > > > Currently we assign all maps to main thread. Adding > > > code that spreads maps for --threads option.

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-24 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 23, 2018 at 09:44:32PM +0200, Jiri Olsa escreveu: > On Mon, Sep 17, 2018 at 08:40:48PM +0900, Namhyung Kim wrote: > > On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > > > Currently we assign all maps to main thread. Adding > > > code that spreads maps for --threads option.

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-23 Thread Jiri Olsa
On Mon, Sep 17, 2018 at 08:40:48PM +0900, Namhyung Kim wrote: > On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > > Currently we assign all maps to main thread. Adding > > code that spreads maps for --threads option. > > > > For --thread option we create as many threads as there > >

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-23 Thread Jiri Olsa
On Mon, Sep 17, 2018 at 08:40:48PM +0900, Namhyung Kim wrote: > On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > > Currently we assign all maps to main thread. Adding > > code that spreads maps for --threads option. > > > > For --thread option we create as many threads as there > >

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-17 Thread Namhyung Kim
On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > Currently we assign all maps to main thread. Adding > code that spreads maps for --threads option. > > For --thread option we create as many threads as there > are memory maps in evlist, which is the number of CPUs > in the system or

Re: [PATCH 47/48] perf record: Spread maps for --threads option

2018-09-17 Thread Namhyung Kim
On Thu, Sep 13, 2018 at 02:54:49PM +0200, Jiri Olsa wrote: > Currently we assign all maps to main thread. Adding > code that spreads maps for --threads option. > > For --thread option we create as many threads as there > are memory maps in evlist, which is the number of CPUs > in the system or

[PATCH 47/48] perf record: Spread maps for --threads option

2018-09-13 Thread Jiri Olsa
Currently we assign all maps to main thread. Adding code that spreads maps for --threads option. For --thread option we create as many threads as there are memory maps in evlist, which is the number of CPUs in the system or CPUs we monitor. Each thread gets a single data mmap to read. In

[PATCH 47/48] perf record: Spread maps for --threads option

2018-09-13 Thread Jiri Olsa
Currently we assign all maps to main thread. Adding code that spreads maps for --threads option. For --thread option we create as many threads as there are memory maps in evlist, which is the number of CPUs in the system or CPUs we monitor. Each thread gets a single data mmap to read. In