Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi all, On 2016/11/24 18:10, Thomas Petazzoni wrote: > Hello, > > On Thu, 24 Nov 2016 10:49:23 +0100, Marcin Wojtas wrote: > >> How about to avoid confusion, by simply renaming this number to >> port-id/xenon-id or anything else but slot? I guess this may allow to >> avoid some

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi all, On 2016/11/24 18:10, Thomas Petazzoni wrote: > Hello, > > On Thu, 24 Nov 2016 10:49:23 +0100, Marcin Wojtas wrote: > >> How about to avoid confusion, by simply renaming this number to >> port-id/xenon-id or anything else but slot? I guess this may allow to >> avoid some

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hello, On Thu, 24 Nov 2016 10:49:23 +0100, Marcin Wojtas wrote: > How about to avoid confusion, by simply renaming this number to > port-id/xenon-id or anything else but slot? I guess this may allow to > avoid some misunderstandings. Agreed. Thomas -- Thomas Petazzoni, CTO, Free Electrons

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hello, On Thu, 24 Nov 2016 10:49:23 +0100, Marcin Wojtas wrote: > How about to avoid confusion, by simply renaming this number to > port-id/xenon-id or anything else but slot? I guess this may allow to > avoid some misunderstandings. Agreed. Thomas -- Thomas Petazzoni, CTO, Free Electrons

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Thursday, November 24, 2016 10:48:58 AM CET Thomas Petazzoni wrote: > Hello, > > On Thu, 24 Nov 2016 10:44:48 +0100, Gregory CLEMENT wrote: > > > "A single Xenon IP can support multiple slots. > > Each slot acts as an independent SDHC. It owns independent resources, such > > as register sets

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Thursday, November 24, 2016 10:48:58 AM CET Thomas Petazzoni wrote: > Hello, > > On Thu, 24 Nov 2016 10:44:48 +0100, Gregory CLEMENT wrote: > > > "A single Xenon IP can support multiple slots. > > Each slot acts as an independent SDHC. It owns independent resources, such > > as register sets

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hello, On Thu, 24 Nov 2016 10:44:48 +0100, Gregory CLEMENT wrote: > "A single Xenon IP can support multiple slots. > Each slot acts as an independent SDHC. It owns independent resources, such > as register sets clock and PHY. > Each slot should have an independent device tree node." I think

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hello, On Thu, 24 Nov 2016 10:44:48 +0100, Gregory CLEMENT wrote: > "A single Xenon IP can support multiple slots. > Each slot acts as an independent SDHC. It owns independent resources, such > as register sets clock and PHY. > Each slot should have an independent device tree node." I think

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Gregory, 2016-11-24 10:44 GMT+01:00 Gregory CLEMENT : > Hi Arnd, > > On jeu., nov. 24 2016, Arnd Bergmann wrote: > >> On Thursday, November 24, 2016 10:22:31 AM CET Gregory CLEMENT wrote: >>> >>> I don't have an option for mmc in general,

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Gregory, 2016-11-24 10:44 GMT+01:00 Gregory CLEMENT : > Hi Arnd, > > On jeu., nov. 24 2016, Arnd Bergmann wrote: > >> On Thursday, November 24, 2016 10:22:31 AM CET Gregory CLEMENT wrote: >>> >>> I don't have an option for mmc in general, but using child node do not >>> fit at all the xenon

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Thursday, November 24, 2016 10:22:31 AM CET Gregory CLEMENT wrote: > > I don't have an option for mmc in general, but using child node do not > fit at all the xenon controller. > > For this controller each slot has its own set of register, so there is > no common ressource to share so no

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Thursday, November 24, 2016 10:22:31 AM CET Gregory CLEMENT wrote: > > I don't have an option for mmc in general, but using child node do not > fit at all the xenon controller. > > For this controller each slot has its own set of register, so there is > no common ressource to share so no

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Arnd, On jeu., nov. 24 2016, Arnd Bergmann wrote: > On Thursday, November 24, 2016 10:05:45 AM CET Ulf Hansson wrote: >> > You also mentioned other bindings using child nodes, but for this one >> > we have one controller with only one set of register with multiple slots >> >

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Arnd, On jeu., nov. 24 2016, Arnd Bergmann wrote: > On Thursday, November 24, 2016 10:05:45 AM CET Ulf Hansson wrote: >> > You also mentioned other bindings using child nodes, but for this one >> > we have one controller with only one set of register with multiple slots >> > (Atmel is an

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Thursday, November 24, 2016 10:05:45 AM CET Ulf Hansson wrote: > > You also mentioned other bindings using child nodes, but for this one > > we have one controller with only one set of register with multiple slots > > (Atmel is an example). Here each slot have it own set of register. > > > >

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Thursday, November 24, 2016 10:05:45 AM CET Ulf Hansson wrote: > > You also mentioned other bindings using child nodes, but for this one > > we have one controller with only one set of register with multiple slots > > (Atmel is an example). Here each slot have it own set of register. > > > >

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On 22 November 2016 at 18:23, Gregory CLEMENT wrote: > Hi Rob, > > On jeu., nov. 10 2016, Ziji Hu wrote: > > [...] > + +- reg: + * For "marvell,xenon-sdhci", one register area for Xenon IP. + + * For

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On 22 November 2016 at 18:23, Gregory CLEMENT wrote: > Hi Rob, > > On jeu., nov. 10 2016, Ziji Hu wrote: > > [...] > + +- reg: + * For "marvell,xenon-sdhci", one register area for Xenon IP. + + * For "marvell,armada-3700-sdhci", two register areas. +The first

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On jeu., nov. 10 2016, Ziji Hu wrote: [...] >>> + >>> +- reg: >>> + * For "marvell,xenon-sdhci", one register area for Xenon IP. >>> + >>> + * For "marvell,armada-3700-sdhci", two register areas. >>> +The first one for Xenon IP register. The second one for

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On jeu., nov. 10 2016, Ziji Hu wrote: [...] >>> + >>> +- reg: >>> + * For "marvell,xenon-sdhci", one register area for Xenon IP. >>> + >>> + * For "marvell,armada-3700-sdhci", two register areas. >>> +The first one for Xenon IP register. The second one for the Armada >>> 3700

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Fri, 11 Nov 2016 11:22:43 +0800 Jisheng Zhang wrote: > Hi Rob, Ziji, > > On Thu, 10 Nov 2016 19:44:19 +0800 Ziji Hu wrote: > > > Hi Rob, > > > > On 2016/11/10 2:24, Rob Herring wrote: > > > On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: > > >> From: Ziji Hu

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Fri, 11 Nov 2016 11:22:43 +0800 Jisheng Zhang wrote: > Hi Rob, Ziji, > > On Thu, 10 Nov 2016 19:44:19 +0800 Ziji Hu wrote: > > > Hi Rob, > > > > On 2016/11/10 2:24, Rob Herring wrote: > > > On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: > > >> From: Ziji Hu > > >> >

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, Ziji, On Thu, 10 Nov 2016 19:44:19 +0800 Ziji Hu wrote: > Hi Rob, > > On 2016/11/10 2:24, Rob Herring wrote: > > On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: > >> From: Ziji Hu > >> > >> Marvell Xenon SDHC can support eMMC/SD/SDIO. > >> Add

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, Ziji, On Thu, 10 Nov 2016 19:44:19 +0800 Ziji Hu wrote: > Hi Rob, > > On 2016/11/10 2:24, Rob Herring wrote: > > On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: > >> From: Ziji Hu > >> > >> Marvell Xenon SDHC can support eMMC/SD/SDIO. > >> Add Xenon-specific

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On 2016/11/10 2:24, Rob Herring wrote: > On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also add properties for Xenon PHY setting. >> >>

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On 2016/11/10 2:24, Rob Herring wrote: > On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also add properties for Xenon PHY setting. >> >> Signed-off-by: Hu Ziji >>

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon SDHC can support eMMC/SD/SDIO. > Add Xenon-specific properties. > Also add properties for Xenon PHY setting. > > Signed-off-by: Hu Ziji > Signed-off-by:

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Mon, Oct 31, 2016 at 12:09:54PM +0100, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon SDHC can support eMMC/SD/SDIO. > Add Xenon-specific properties. > Also add properties for Xenon PHY setting. > > Signed-off-by: Hu Ziji > Signed-off-by: Gregory CLEMENT > --- >

[PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

From: Ziji Hu Marvell Xenon SDHC can support eMMC/SD/SDIO. Add Xenon-specific properties. Also add properties for Xenon PHY setting. Signed-off-by: Hu Ziji Signed-off-by: Gregory CLEMENT ---

[PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

From: Ziji Hu Marvell Xenon SDHC can support eMMC/SD/SDIO. Add Xenon-specific properties. Also add properties for Xenon PHY setting. Signed-off-by: Hu Ziji Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt | 161 +++- MAINTAINERS

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On mar., oct. 11 2016, Ziji Hu wrote: [...] >>> + Different Xenon SDHC release has different register set size. >>> + The specific size should also refer to the SOC implementation. >>> + >>> +Optional Properties: >>> +- Slot Index >>> + A single Xenon IP can

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On mar., oct. 11 2016, Ziji Hu wrote: [...] >>> + Different Xenon SDHC release has different register set size. >>> + The specific size should also refer to the SOC implementation. >>> + >>> +Optional Properties: >>> +- Slot Index >>> + A single Xenon IP can support multiple slots.

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, Thanks a for the review. It is really helpful to me. On 2016/10/11 5:34, Rob Herring wrote: > On Fri, Oct 07, 2016 at 05:22:51PM +0200, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, Thanks a for the review. It is really helpful to me. On 2016/10/11 5:34, Rob Herring wrote: > On Fri, Oct 07, 2016 at 05:22:51PM +0200, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Fri, Oct 07, 2016 at 05:22:51PM +0200, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon SDHC can support eMMC/SD/SDIO. > Add Xenon-specific properties. > Also add properties for Xenon PHY setting. > > Signed-off-by: Hu Ziji > Reviewed-by:

Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

On Fri, Oct 07, 2016 at 05:22:51PM +0200, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon SDHC can support eMMC/SD/SDIO. > Add Xenon-specific properties. > Also add properties for Xenon PHY setting. > > Signed-off-by: Hu Ziji > Reviewed-by: Gregory CLEMENT > Signed-off-by: Gregory

[PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

From: Ziji Hu Marvell Xenon SDHC can support eMMC/SD/SDIO. Add Xenon-specific properties. Also add properties for Xenon PHY setting. Signed-off-by: Hu Ziji Reviewed-by: Gregory CLEMENT Signed-off-by: Gregory CLEMENT

[PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

From: Ziji Hu Marvell Xenon SDHC can support eMMC/SD/SDIO. Add Xenon-specific properties. Also add properties for Xenon PHY setting. Signed-off-by: Hu Ziji Reviewed-by: Gregory CLEMENT Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/bindings/mmc/marvell,sdhci-xenon.txt | 164