Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-24 Thread Aaron Lu
Hi Betty, On Tue, Jul 24, 2012 at 12:55:06PM -0600, Betty Dall wrote: > > > > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > > > > index 2f159aa..78c4226 100644 > > > > --- a/drivers/scsi/sr.c > > > > +++ b/drivers/scsi/sr.c > > > > @@ -869,6 +869,7 @@ static int sr_probe(struct device

Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-24 Thread Betty Dall
Hi Aaron, On Tue, 2012-07-24 at 07:52 +0800, Aaron Lu wrote: > On Mon, Jul 23, 2012 at 12:43:34PM -0600, Betty Dall wrote: > > Hi Aaron, > > Hi, > > > > > On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote: > > > Set the ODD's in kernel poll interval to 2s for the user in case the > > > user is

Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-24 Thread Betty Dall
Hi Aaron, On Tue, 2012-07-24 at 07:52 +0800, Aaron Lu wrote: On Mon, Jul 23, 2012 at 12:43:34PM -0600, Betty Dall wrote: Hi Aaron, Hi, On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote: Set the ODD's in kernel poll interval to 2s for the user in case the user is using an old

Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-24 Thread Aaron Lu
Hi Betty, On Tue, Jul 24, 2012 at 12:55:06PM -0600, Betty Dall wrote: diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index 2f159aa..78c4226 100644 --- a/drivers/scsi/sr.c +++ b/drivers/scsi/sr.c @@ -869,6 +869,7 @@ static int sr_probe(struct device *dev)

Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-23 Thread Aaron Lu
On Mon, Jul 23, 2012 at 12:43:34PM -0600, Betty Dall wrote: > Hi Aaron, Hi, > > On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote: > > Set the ODD's in kernel poll interval to 2s for the user in case the > > user is using an old distro on which udev will not set the system wide > > block

Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-23 Thread Betty Dall
Hi Aaron, On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote: > Set the ODD's in kernel poll interval to 2s for the user in case the > user is using an old distro on which udev will not set the system wide > block parameter events_dfl_poll_msecs. Why did you pick 2 seconds? > > Signed-off-by:

[PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-23 Thread Aaron Lu
Set the ODD's in kernel poll interval to 2s for the user in case the user is using an old distro on which udev will not set the system wide block parameter events_dfl_poll_msecs. Signed-off-by: Aaron Lu --- block/genhd.c | 23 +-- drivers/scsi/sr.c | 1 +

[PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-23 Thread Aaron Lu
Set the ODD's in kernel poll interval to 2s for the user in case the user is using an old distro on which udev will not set the system wide block parameter events_dfl_poll_msecs. Signed-off-by: Aaron Lu aaron...@amd.com --- block/genhd.c | 23 +-- drivers/scsi/sr.c

Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-23 Thread Betty Dall
Hi Aaron, On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote: Set the ODD's in kernel poll interval to 2s for the user in case the user is using an old distro on which udev will not set the system wide block parameter events_dfl_poll_msecs. Why did you pick 2 seconds? Signed-off-by: Aaron

Re: [PATCH 5/5] block: genhd: add an interface to set disk's poll interval

2012-07-23 Thread Aaron Lu
On Mon, Jul 23, 2012 at 12:43:34PM -0600, Betty Dall wrote: Hi Aaron, Hi, On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote: Set the ODD's in kernel poll interval to 2s for the user in case the user is using an old distro on which udev will not set the system wide block parameter