Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-30 Thread OGAWA Hirofumi
Namjae Jeon writes: > 2012/10/30, Andrew Morton : >> On Sun, 28 Oct 2012 10:53:43 +0900 >> Namjae Jeon wrote: >> >>> From: Namjae Jeon >>> >>> fat_nfs_get_inode does not hold i_mutex of parent directory.So add >>> lock to fat_build_inode. >> > Hi. Andrew. >> Well.. why? Presumably this patch

Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-30 Thread OGAWA Hirofumi
Namjae Jeon linkinj...@gmail.com writes: 2012/10/30, Andrew Morton a...@linux-foundation.org: On Sun, 28 Oct 2012 10:53:43 +0900 Namjae Jeon linkinj...@gmail.com wrote: From: Namjae Jeon namjae.j...@samsung.com fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to

Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-29 Thread Namjae Jeon
2012/10/30, Andrew Morton : > On Sun, 28 Oct 2012 10:53:43 +0900 > Namjae Jeon wrote: > >> From: Namjae Jeon >> >> fat_nfs_get_inode does not hold i_mutex of parent directory.So add >> lock to fat_build_inode. > Hi. Andrew. > Well.. why? Presumably this patch fixes some race. A good >

Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-29 Thread Andrew Morton
On Sun, 28 Oct 2012 10:53:43 +0900 Namjae Jeon wrote: > From: Namjae Jeon > > fat_nfs_get_inode does not hold i_mutex of parent directory.So add > lock to fat_build_inode. Well.. why? Presumably this patch fixes some race. A good description of that race would be useful - partly because

Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-29 Thread Andrew Morton
On Sun, 28 Oct 2012 10:53:43 +0900 Namjae Jeon linkinj...@gmail.com wrote: From: Namjae Jeon namjae.j...@samsung.com fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to fat_build_inode. Well.. why? Presumably this patch fixes some race. A good description of that

Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-29 Thread Namjae Jeon
2012/10/30, Andrew Morton a...@linux-foundation.org: On Sun, 28 Oct 2012 10:53:43 +0900 Namjae Jeon linkinj...@gmail.com wrote: From: Namjae Jeon namjae.j...@samsung.com fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to fat_build_inode. Hi. Andrew. Well.. why?

[PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to fat_build_inode. Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar N Signed-off-by: Amit Sahrawat --- fs/fat/fat.h |1 + fs/fat/inode.c | 15 +++ 2 files changed, 16

[PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to fat_build_inode. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ravishankar N ravi...@samsung.com Signed-off-by: Amit Sahrawat a.sahra...@samsung.com ---