Re: [PATCH 5/5] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-22 Thread Mike Kravetz
On 7/22/20 1:49 AM, Baoquan He wrote: > On 07/20/20 at 05:38pm, Mike Kravetz wrote: >>> + if (count != h->max_huge_pages) { >>> + char buf[32]; >>> + >>> + string_get_size(huge_page_size(h), 1, STRING_UNITS_2, buf, 32); >>> + pr_warn("HugeTLB: %s %lu of page size %s

Re: [PATCH 5/5] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-22 Thread Baoquan He
Hi Mike, On 07/20/20 at 05:38pm, Mike Kravetz wrote: > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 467894d8332a..1dfb5d9e4e06 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -2661,7 +2661,7 @@ static int adjust_pool_surplus(struct hstate *h, > > nodemask_t *nodes_allowed, >

Re: [PATCH 5/5] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-21 Thread Baoquan He
On 07/20/20 at 05:38pm, Mike Kravetz wrote: > On 7/19/20 11:26 PM, Baoquan He wrote: > > A customer complained that no any message is printed out when failed to > > allocate explicitly specified number of persistent huge pages. That > > specifying can be done by writing into

Re: [PATCH 5/5] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-20 Thread Mike Kravetz
On 7/19/20 11:26 PM, Baoquan He wrote: > A customer complained that no any message is printed out when failed to > allocate explicitly specified number of persistent huge pages. That > specifying can be done by writing into /proc/sys/vm/nr_hugepages to > increase the persisten huge pages. > > In

[PATCH 5/5] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-20 Thread Baoquan He
A customer complained that no any message is printed out when failed to allocate explicitly specified number of persistent huge pages. That specifying can be done by writing into /proc/sys/vm/nr_hugepages to increase the persisten huge pages. In the current code, it takes the best effort way to