Re: [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting

2019-07-30 Thread Dietmar Eggemann
On 7/30/19 9:23 AM, Peter Zijlstra wrote: > On Mon, Jul 29, 2019 at 05:59:04PM +0100, Dietmar Eggemann wrote: >> On 7/29/19 5:54 PM, Peter Zijlstra wrote: >>> On Fri, Jul 26, 2019 at 12:18:19PM +0200, luca abeni wrote: Hi Dietmar, On Fri, 26 Jul 2019 09:27:56 +0100 Dietmar

Re: [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting

2019-07-30 Thread Peter Zijlstra
On Mon, Jul 29, 2019 at 05:59:04PM +0100, Dietmar Eggemann wrote: > On 7/29/19 5:54 PM, Peter Zijlstra wrote: > > On Fri, Jul 26, 2019 at 12:18:19PM +0200, luca abeni wrote: > >> Hi Dietmar, > >> > >> On Fri, 26 Jul 2019 09:27:56 +0100 > >> Dietmar Eggemann wrote: > >> > >>> To make the decision

Re: [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting

2019-07-29 Thread Dietmar Eggemann
On 7/29/19 5:54 PM, Peter Zijlstra wrote: > On Fri, Jul 26, 2019 at 12:18:19PM +0200, luca abeni wrote: >> Hi Dietmar, >> >> On Fri, 26 Jul 2019 09:27:56 +0100 >> Dietmar Eggemann wrote: >> >>> To make the decision whether to set rq or running bw to 0 in underflow >>> case use the return value of

Re: [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting

2019-07-29 Thread Peter Zijlstra
On Fri, Jul 26, 2019 at 12:18:19PM +0200, luca abeni wrote: > Hi Dietmar, > > On Fri, 26 Jul 2019 09:27:56 +0100 > Dietmar Eggemann wrote: > > > To make the decision whether to set rq or running bw to 0 in underflow > > case use the return value of SCHED_WARN_ON() rather than an extra if > >

Re: [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting

2019-07-26 Thread luca abeni
Hi Dietmar, On Fri, 26 Jul 2019 09:27:56 +0100 Dietmar Eggemann wrote: > To make the decision whether to set rq or running bw to 0 in underflow > case use the return value of SCHED_WARN_ON() rather than an extra if > condition. I think I tried this at some point, but if I remember well this

[PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting

2019-07-26 Thread Dietmar Eggemann
To make the decision whether to set rq or running bw to 0 in underflow case use the return value of SCHED_WARN_ON() rather than an extra if condition. Signed-off-by: Dietmar Eggemann --- kernel/sched/deadline.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git