Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread SIMRAN SINGHAL
On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall wrote: >> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void >> *pcontext) >> { >> unsigned long irql; >> struct recv_reorder_ctrl *preorder_ctrl = >> - (struct

Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread SIMRAN SINGHAL
On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall wrote: >> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void >> *pcontext) >> { >> unsigned long irql; >> struct recv_reorder_ctrl *preorder_ctrl = >> - (struct recv_reorder_ctrl *)pcontext;

Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread Julia Lawall
> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext) > { > unsigned long irql; > struct recv_reorder_ctrl *preorder_ctrl = > - (struct recv_reorder_ctrl *)pcontext; > + pcontext; Coccinelle doesn't

Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread Julia Lawall
> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext) > { > unsigned long irql; > struct recv_reorder_ctrl *preorder_ctrl = > - (struct recv_reorder_ctrl *)pcontext; > + pcontext; Coccinelle doesn't

[PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 10 +- 1 file

[PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 10 +- 1 file changed, 5 insertions(+), 5