Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

on 2015/12/6 6:52, Steven Rostedt wrote: > On Sat, 5 Dec 2015 18:12:57 +0100 (CET) > Thomas Gleixner wrote: > >> On Fri, 4 Dec 2015, Li Bin wrote: >>> --- a/arch/x86/kernel/ftrace.c >>> +++ b/arch/x86/kernel/ftrace.c >>> @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned

Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

On Sat, 5 Dec 2015 18:12:57 +0100 (CET) Thomas Gleixner wrote: > On Fri, 4 Dec 2015, Li Bin wrote: > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/kernel/ftrace.c > > @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned > > const char *old_code, > > unsigned char

Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

On Fri, 4 Dec 2015, Li Bin wrote: > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned > const char *old_code, > unsigned char replaced[MCOUNT_INSN_SIZE]; > > /* > - * Note: Due to modules

Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

On Fri, 4 Dec 2015, Li Bin wrote: > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned > const char *old_code, > unsigned char replaced[MCOUNT_INSN_SIZE]; > > /* > - * Note: Due to modules

Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

On Sat, 5 Dec 2015 18:12:57 +0100 (CET) Thomas Gleixner wrote: > On Fri, 4 Dec 2015, Li Bin wrote: > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/kernel/ftrace.c > > @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned > > const char *old_code, >

Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

on 2015/12/6 6:52, Steven Rostedt wrote: > On Sat, 5 Dec 2015 18:12:57 +0100 (CET) > Thomas Gleixner wrote: > >> On Fri, 4 Dec 2015, Li Bin wrote: >>> --- a/arch/x86/kernel/ftrace.c >>> +++ b/arch/x86/kernel/ftrace.c >>> @@ -106,13 +106,12 @@

[PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such

[PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such