Re: [PATCH 5/5 linux-next V2 (resend)] cifs: Combine set_file_size by handle and path into one function

2013-12-09 Thread Jeff Layton
On Sun, 8 Dec 2013 14:13:37 -0700 Tim Gardner wrote: > As suggested by Jeff Layton: > > > "Now that I look though, it's clear to me that cifs_set_file_size is > just wrong. Currently it calls ops->set_path_size and if that fails > with certain error codes it tries to do a

Re: [PATCH 5/5 linux-next V2 (resend)] cifs: Combine set_file_size by handle and path into one function

2013-12-09 Thread Jeff Layton
On Sun, 8 Dec 2013 14:13:37 -0700 Tim Gardner t...@tpi.com wrote: As suggested by Jeff Layton: Now that I look though, it's clear to me that cifs_set_file_size is just wrong. Currently it calls ops-set_path_size and if that fails with certain error codes it tries to do a

[PATCH 5/5 linux-next V2 (resend)] cifs: Combine set_file_size by handle and path into one function

2013-12-08 Thread Tim Gardner
As suggested by Jeff Layton: "Now that I look though, it's clear to me that cifs_set_file_size is just wrong. Currently it calls ops->set_path_size and if that fails with certain error codes it tries to do a SMBLegacyOpen, etc. That's going to fall on its face if this is a SMB2/3

[PATCH 5/5 linux-next V2 (resend)] cifs: Combine set_file_size by handle and path into one function

2013-12-08 Thread Tim Gardner
As suggested by Jeff Layton: Now that I look though, it's clear to me that cifs_set_file_size is just wrong. Currently it calls ops-set_path_size and if that fails with certain error codes it tries to do a SMBLegacyOpen, etc. That's going to fall on its face if this is a SMB2/3