Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency

2015-08-24 Thread Wolfram Sang
On Wed, Aug 19, 2015 at 01:19:57PM +0200, Javier Martinez Canillas wrote: > The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but > MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends > on is bad practice as it may lead to circular Kconfig dependencies. > > Since the

Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency

2015-08-24 Thread Wolfram Sang
On Wed, Aug 19, 2015 at 01:19:57PM +0200, Javier Martinez Canillas wrote: The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends on is bad practice as it may lead to circular Kconfig dependencies. Since the

[PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency

2015-08-19 Thread Javier Martinez Canillas
The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends on is bad practice as it may lead to circular Kconfig dependencies. Since the platform device that is matched with the I2C bus driver is registered by the ChromeOS

[PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency

2015-08-19 Thread Javier Martinez Canillas
The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends on is bad practice as it may lead to circular Kconfig dependencies. Since the platform device that is matched with the I2C bus driver is registered by the ChromeOS