Re: [PATCH 5/6] n_tty: Fix stuck write wakeup

2015-12-13 Thread Johannes Stezenbach
On Sun, Dec 13, 2015 at 10:38:02AM -0800, Peter Hurley wrote: > On 12/13/2015 07:18 AM, Johannes Stezenbach wrote: > > > > There is a related bug that I meant to send a patch, but I > > never got around because the issue was found with proprietary > > userspace and ancient kernel. Maybe you could

Re: [PATCH 5/6] n_tty: Fix stuck write wakeup

2015-12-13 Thread Peter Hurley
On 12/13/2015 07:18 AM, Johannes Stezenbach wrote: > Hi Peter, > > On Sat, Dec 12, 2015 at 02:16:38PM -0800, Peter Hurley wrote: >> If signal-driven i/o is disabled while write wakeup is pending (ie., >> n_tty_write() has set TTY_DO_WRITE_WAKEUP but then signal-driven i/o >> is disabled), the TTY_

Re: [PATCH 5/6] n_tty: Fix stuck write wakeup

2015-12-13 Thread Johannes Stezenbach
Hi Peter, On Sat, Dec 12, 2015 at 02:16:38PM -0800, Peter Hurley wrote: > If signal-driven i/o is disabled while write wakeup is pending (ie., > n_tty_write() has set TTY_DO_WRITE_WAKEUP but then signal-driven i/o > is disabled), the TTY_DO_WRITE_WAKEUP bit will never be cleared and > will cause t

[PATCH 5/6] n_tty: Fix stuck write wakeup

2015-12-12 Thread Peter Hurley
If signal-driven i/o is disabled while write wakeup is pending (ie., n_tty_write() has set TTY_DO_WRITE_WAKEUP but then signal-driven i/o is disabled), the TTY_DO_WRITE_WAKEUP bit will never be cleared and will cause tty_wakeup() to always call n_tty_write_wakeup. Unconditionally clear the write w