Re: [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator

2019-01-31 Thread Hsin-hsiung Wang
Hi Mark, On Wed, 2019-01-30 at 15:18 +, Mark Brown wrote: > On Wed, Jan 30, 2019 at 05:18:10PM +0800, Hsin-Hsiung Wang wrote: > > > +static const struct of_device_id mt6358_of_match[] = { > > + { .compatible = "mediatek,mt6358-regulator", }, > > + { /* sentinel */ }, > > +}; > > +MODULE_D

Re: [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator

2019-01-30 Thread Mark Brown
On Wed, Jan 30, 2019 at 05:18:10PM +0800, Hsin-Hsiung Wang wrote: > +static const struct of_device_id mt6358_of_match[] = { > + { .compatible = "mediatek,mt6358-regulator", }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, mt6358_of_match); There should be no need for a separate

[PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator

2019-01-30 Thread Hsin-Hsiung Wang
The MT6358 is a regulator found on boards based on MediaTek MT8183 and probably other SoCs. It is a so called pmic and connects as a slave to SoC using SPI, wrapped inside the pmic-wrapper. Signed-off-by: Hsin-Hsiung Wang --- drivers/regulator/Kconfig | 9 + drivers/regulator/