Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Viresh Kumar
On 08-09-20, 17:38, Amit Kucheria wrote: > On Tue, Sep 8, 2020 at 5:18 PM Amit Kucheria wrote: > > > > On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote: > > > > > > On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > > > > On 0908, Viresh Kumar wrote: > > > > > On 08-09-20, 13:27, Manivannan

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Bjorn Andersson
On Tue 08 Sep 02:57 CDT 2020, Manivannan Sadhasivam wrote: > Use regmap for accessing cpufreq registers in hardware. > The content of the patch looks good, but in itself I don't see the reason for migrating to regmap. If you have subsequent patches, that would benefit from describing the

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Manivannan Sadhasivam
On 0908, Amit Kucheria wrote: > On Tue, Sep 8, 2020 at 5:18 PM Amit Kucheria wrote: > > > > On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote: > > > > > > On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > > > > On 0908, Viresh Kumar wrote: > > > > > On 08-09-20, 13:27, Manivannan Sadhasivam

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Sudeep Holla
On Tue, Sep 08, 2020 at 05:18:35PM +0530, Amit Kucheria wrote: > On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote: > > > > On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > > > On 0908, Viresh Kumar wrote: > > > > On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > > > > > Use regmap for

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Amit Kucheria
On Tue, Sep 8, 2020 at 5:18 PM Amit Kucheria wrote: > > On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote: > > > > On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > > > On 0908, Viresh Kumar wrote: > > > > On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > > > > > Use regmap for accessing

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Manivannan Sadhasivam
On 0908, Viresh Kumar wrote: > On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > > Use regmap for accessing cpufreq registers in hardware. > > Why ? Please mention why a change is required in the log. > Only because it is recommended to use regmap for abstracting the hw access. Moreover it

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Viresh Kumar
On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > On 0908, Viresh Kumar wrote: > > On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > > > Use regmap for accessing cpufreq registers in hardware. > > > > Why ? Please mention why a change is required in the log. > > > > Only because it is

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Amit Kucheria
On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote: > > On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > > On 0908, Viresh Kumar wrote: > > > On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > > > > Use regmap for accessing cpufreq registers in hardware. > > > > > > Why ? Please mention why a

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Manivannan Sadhasivam
On 0908, Viresh Kumar wrote: > On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > > On 0908, Viresh Kumar wrote: > > > On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > > > > Use regmap for accessing cpufreq registers in hardware. > > > > > > Why ? Please mention why a change is required in the

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Viresh Kumar
On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > Use regmap for accessing cpufreq registers in hardware. Why ? Please mention why a change is required in the log. > Signed-off-by: Manivannan Sadhasivam > --- > drivers/cpufreq/qcom-cpufreq-hw.c | 55 ++- > 1 file

[PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Manivannan Sadhasivam
Use regmap for accessing cpufreq registers in hardware. Signed-off-by: Manivannan Sadhasivam --- drivers/cpufreq/qcom-cpufreq-hw.c | 55 ++- 1 file changed, 47 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c