Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-10-28 Thread Steven Rostedt
On Tue, 28 Oct 2014 07:31:32 -0700 Joe Perches wrote: > > I wouldn't change logic on this. There's no reason to call this > > function if it isn't doing anything. > > > > I'll change this to just do the update and not change logic like this. > > Fewer #ifdefs > And there's other ways to

Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-10-28 Thread Joe Perches
On Tue, 2014-10-28 at 10:11 -0400, Steven Rostedt wrote: > On Mon, 29 Sep 2014 16:08:25 -0700 > Joe Perches wrote: > > > seq_printf functions shouldn't really check the return value. > > Checking seq_is_full occasionally is used instead. > > > > Update vfs documentation. > > > > Signed-off-by:

Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-10-28 Thread Steven Rostedt
On Mon, 29 Sep 2014 16:08:25 -0700 Joe Perches wrote: > seq_printf functions shouldn't really check the return value. > Checking seq_is_full occasionally is used instead. > > Update vfs documentation. > > Signed-off-by: Joe Perches > > -#ifdef CONFIG_PROC_FS > -static int

Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-10-28 Thread Steven Rostedt
On Mon, 29 Sep 2014 16:08:25 -0700 Joe Perches j...@perches.com wrote: seq_printf functions shouldn't really check the return value. Checking seq_is_full occasionally is used instead. Update vfs documentation. Signed-off-by: Joe Perches j...@perches.com -#ifdef CONFIG_PROC_FS

Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-10-28 Thread Joe Perches
On Tue, 2014-10-28 at 10:11 -0400, Steven Rostedt wrote: On Mon, 29 Sep 2014 16:08:25 -0700 Joe Perches j...@perches.com wrote: seq_printf functions shouldn't really check the return value. Checking seq_is_full occasionally is used instead. Update vfs documentation.

Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-10-28 Thread Steven Rostedt
On Tue, 28 Oct 2014 07:31:32 -0700 Joe Perches j...@perches.com wrote: I wouldn't change logic on this. There's no reason to call this function if it isn't doing anything. I'll change this to just do the update and not change logic like this. Fewer #ifdefs And there's other ways

[PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-09-29 Thread Joe Perches
seq_printf functions shouldn't really check the return value. Checking seq_is_full occasionally is used instead. Update vfs documentation. Signed-off-by: Joe Perches --- Documentation/filesystems/vfs.txt | 2 +- drivers/net/tun.c | 4 +-- fs/eventfd.c |

[PATCH 5/7] fs: Convert show_fdinfo functions to void

2014-09-29 Thread Joe Perches
seq_printf functions shouldn't really check the return value. Checking seq_is_full occasionally is used instead. Update vfs documentation. Signed-off-by: Joe Perches j...@perches.com --- Documentation/filesystems/vfs.txt | 2 +- drivers/net/tun.c | 4 +-- fs/eventfd.c