Re: [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field

2021-01-27 Thread Paul Gortmaker
[Re: [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field] On 26/01/2021 (Tue 18:58) Yury Norov wrote: > On Tue, Jan 26, 2021 at 1:22 PM Andy Shevchenko > wrote: > > > > On Tue, Jan 26, 2021 at 12:11:38PM -0500, Paul Gortmaker wrote: > > > The bitm

Re: [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field

2021-01-26 Thread Yury Norov
On Tue, Jan 26, 2021 at 1:22 PM Andy Shevchenko wrote: > > On Tue, Jan 26, 2021 at 12:11:38PM -0500, Paul Gortmaker wrote: > > The bitmap_getnum is only used on a region's start/end/off/group_len > > field. Trivially decouple the region from the field so that the region > > pointer is available f

Re: [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field

2021-01-26 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 12:11:38PM -0500, Paul Gortmaker wrote: > The bitmap_getnum is only used on a region's start/end/off/group_len > field. Trivially decouple the region from the field so that the region > pointer is available for a pending change. Honestly, I don't like this macro trick. It'

[PATCH 5/8] lib: bitmap_getnum: separate arg into region and field

2021-01-26 Thread Paul Gortmaker
The bitmap_getnum is only used on a region's start/end/off/group_len field. Trivially decouple the region from the field so that the region pointer is available for a pending change. Cc: Yury Norov Cc: Rasmus Villemoes Cc: Andy Shevchenko Signed-off-by: Paul Gortmaker --- lib/bitmap.c | 9 ++