Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Lukas Wunner
On Mon, Nov 14, 2016 at 01:27:08PM +, Matt Fleming wrote: > On Sun, 13 Nov, at 09:59:32AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > I'll apply the patches from email and add your SOB. > > > > Note that the attached config produces this build error: > > > >

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Lukas Wunner
On Mon, Nov 14, 2016 at 01:27:08PM +, Matt Fleming wrote: > On Sun, 13 Nov, at 09:59:32AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > I'll apply the patches from email and add your SOB. > > > > Note that the attached config produces this build error: > > > >

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Matt Fleming
On Mon, 14 Nov, at 02:55:22PM, Ingo Molnar wrote: > > The problem is not that Ard applied the patches, but that you subsequently > rebased > the tree. For example: > > commit bf5d1f98c1d8be04a40eabb9dd6913347b1b3fc4 > Author: Ard Biesheuvel > AuthorDate: Thu

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Matt Fleming
On Mon, 14 Nov, at 02:55:22PM, Ingo Molnar wrote: > > The problem is not that Ard applied the patches, but that you subsequently > rebased > the tree. For example: > > commit bf5d1f98c1d8be04a40eabb9dd6913347b1b3fc4 > Author: Ard Biesheuvel > AuthorDate: Thu Oct 20 12:21:26 2016 +0100

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Ingo Molnar
* Matt Fleming wrote: > On Sun, 13 Nov, at 08:19:39AM, Ingo Molnar wrote: > > > > * Matt Fleming wrote: > > > > > From: Ard Biesheuvel > > > > > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Ingo Molnar
* Matt Fleming wrote: > On Sun, 13 Nov, at 08:19:39AM, Ingo Molnar wrote: > > > > * Matt Fleming wrote: > > > > > From: Ard Biesheuvel > > > > > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and > > > install the Linux-specific RNG seed UEFI config table. This will be >

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Matt Fleming
On Sun, 13 Nov, at 09:59:32AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > I'll apply the patches from email and add your SOB. > > Note that the attached config produces this build error: > > drivers/firmware/efi/apple-properties.c:149:9: error: implicit declaration of

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Matt Fleming
On Sun, 13 Nov, at 09:59:32AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > I'll apply the patches from email and add your SOB. > > Note that the attached config produces this build error: > > drivers/firmware/efi/apple-properties.c:149:9: error: implicit declaration of > function

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Matt Fleming
On Sun, 13 Nov, at 08:19:39AM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > From: Ard Biesheuvel > > > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and > > install the Linux-specific RNG seed UEFI config table.

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-14 Thread Matt Fleming
On Sun, 13 Nov, at 08:19:39AM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > From: Ard Biesheuvel > > > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and > > install the Linux-specific RNG seed UEFI config table. This will be > > picked up by the EFI routines in the

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-13 Thread Ingo Molnar
* Ingo Molnar wrote: > I'll apply the patches from email and add your SOB. Note that the attached config produces this build error: drivers/firmware/efi/apple-properties.c:149:9: error: implicit declaration of function ‘efi_get_device_by_path’

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-13 Thread Ingo Molnar
* Ingo Molnar wrote: > I'll apply the patches from email and add your SOB. Note that the attached config produces this build error: drivers/firmware/efi/apple-properties.c:149:9: error: implicit declaration of function ‘efi_get_device_by_path’ [-Werror=implicit-function-declaration] also:

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-12 Thread Ingo Molnar
* Matt Fleming wrote: > From: Ard Biesheuvel > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and > install the Linux-specific RNG seed UEFI config table. This will be > picked up by the EFI routines in the core kernel to

Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-12 Thread Ingo Molnar
* Matt Fleming wrote: > From: Ard Biesheuvel > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and > install the Linux-specific RNG seed UEFI config table. This will be > picked up by the EFI routines in the core kernel to seed the kernel > entropy pool. > > Cc: Matt

[PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-12 Thread Matt Fleming
From: Ard Biesheuvel Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and install the Linux-specific RNG seed UEFI config table. This will be picked up by the EFI routines in the core kernel to seed the kernel entropy pool. Cc: Matt Fleming

[PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

2016-11-12 Thread Matt Fleming
From: Ard Biesheuvel Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and install the Linux-specific RNG seed UEFI config table. This will be picked up by the EFI routines in the core kernel to seed the kernel entropy pool. Cc: Matt Fleming Reviewed-by: Kees Cook Signed-off-by: