Re: [PATCH 5/9] perf kvm: add live mode - v3

2013-08-05 Thread David Ahern
On 8/5/13 1:53 AM, Xiao Guangrong wrote: Hi David, Thanks for your nice job! I got some questions. On 08/03/2013 04:05 AM, David Ahern wrote: static int kvm_events_hash_fn(u64 key) { return key & (EVENTS_CACHE_SIZE - 1); @@ -472,7 +501,11 @@ static bool handle_end_event(struct

Re: [PATCH 5/9] perf kvm: add live mode - v3

2013-08-05 Thread David Ahern
On 8/5/13 1:53 AM, Xiao Guangrong wrote: Hi David, Thanks for your nice job! I got some questions. On 08/03/2013 04:05 AM, David Ahern wrote: static int kvm_events_hash_fn(u64 key) { return key (EVENTS_CACHE_SIZE - 1); @@ -472,7 +501,11 @@ static bool handle_end_event(struct

Re: [PATCH 5/9] perf kvm: add live mode - v3

2013-08-04 Thread Xiao Guangrong
Hi David, Thanks for your nice job! I got some questions. On 08/03/2013 04:05 AM, David Ahern wrote: > static int kvm_events_hash_fn(u64 key) > { > return key & (EVENTS_CACHE_SIZE - 1); > @@ -472,7 +501,11 @@ static bool handle_end_event(struct perf_kvm_stat *kvm, >

Re: [PATCH 5/9] perf kvm: add live mode - v3

2013-08-04 Thread Xiao Guangrong
Hi David, Thanks for your nice job! I got some questions. On 08/03/2013 04:05 AM, David Ahern wrote: static int kvm_events_hash_fn(u64 key) { return key (EVENTS_CACHE_SIZE - 1); @@ -472,7 +501,11 @@ static bool handle_end_event(struct perf_kvm_stat *kvm,

[PATCH 5/9] perf kvm: add live mode - v3

2013-08-02 Thread David Ahern
perf kvm stat currently requires back to back record and report commands to see stats. e.g,. perf kvm stat record -p $pid -- sleep 1 perf kvm stat report This is inconvenvient for on box monitoring of a VM. This patch introduces a 'live' mode that in effect combines the record plus report

[PATCH 5/9] perf kvm: add live mode - v3

2013-08-02 Thread David Ahern
perf kvm stat currently requires back to back record and report commands to see stats. e.g,. perf kvm stat record -p $pid -- sleep 1 perf kvm stat report This is inconvenvient for on box monitoring of a VM. This patch introduces a 'live' mode that in effect combines the record plus report