Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-14 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 10:39:14AM +1100, Dave Chinner wrote: > You can't just run an internal log test then add couple of extra > external log tests and say "external logs work fine". > > > Automatic detection if the requirements are met is fine, but this doesn't > > let me easily use say: > >

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-14 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 10:39:14AM +1100, Dave Chinner wrote: > You can't just run an internal log test then add couple of extra > external log tests and say "external logs work fine". > > > Automatic detection if the requirements are met is fine, but this doesn't > > let me easily use say: > >

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Dave Chinner
On Thu, Dec 14, 2017 at 12:00:52AM +0100, Luis R. Rodriguez wrote: > On Thu, Dec 14, 2017 at 08:50:13AM +1100, Dave Chinner wrote: > > On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > > > This should make it easy to run these separately or exclude them. > > > > These should

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Dave Chinner
On Thu, Dec 14, 2017 at 12:00:52AM +0100, Luis R. Rodriguez wrote: > On Thu, Dec 14, 2017 at 08:50:13AM +1100, Dave Chinner wrote: > > On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > > > This should make it easy to run these separately or exclude them. > > > > These should

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 08:50:13AM +1100, Dave Chinner wrote: > On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > > This should make it easy to run these separately or exclude them. > > These should notrun automatically if you don't have an external log > device configured.

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 08:50:13AM +1100, Dave Chinner wrote: > On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > > This should make it easy to run these separately or exclude them. > > These should notrun automatically if you don't have an external log > device configured.

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Dave Chinner
On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > This should make it easy to run these separately or exclude them. These should notrun automatically if you don't have an external log device configured. Every test should either work with an external logdev or explicitly notrun

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Dave Chinner
On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > This should make it easy to run these separately or exclude them. These should notrun automatically if you don't have an external log device configured. Every test should either work with an external logdev or explicitly notrun

[PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-12 Thread Luis R. Rodriguez
This should make it easy to run these separately or exclude them. Signed-off-by: Luis R. Rodriguez --- tests/xfs/group | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/xfs/group b/tests/xfs/group index d23006041ea2..cce98847de53 100644 ---

[PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-12 Thread Luis R. Rodriguez
This should make it easy to run these separately or exclude them. Signed-off-by: Luis R. Rodriguez --- tests/xfs/group | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/xfs/group b/tests/xfs/group index d23006041ea2..cce98847de53 100644 --- a/tests/xfs/group +++