Re: [PATCH 5.11] block: optimise for_each_bvec() advance

2020-11-24 Thread Pavel Begunkov
On 24/11/2020 11:22, Christoph Hellwig wrote: > On Tue, Nov 24, 2020 at 10:21:23AM +, Pavel Begunkov wrote: >> Because of how for_each_bvec() works it never advances across multiple >> entries at a time, so bvec_iter_advance() is an overkill. Add >> specialised bvec_iter_advance_single() that

Re: [PATCH 5.11] block: optimise for_each_bvec() advance

2020-11-24 Thread Pavel Begunkov
On 24/11/2020 11:37, Ming Lei wrote: > On Tue, Nov 24, 2020 at 10:21:23AM +, Pavel Begunkov wrote: >> Because of how for_each_bvec() works it never advances across multiple >> entries at a time, so bvec_iter_advance() is an overkill. Add >> specialised bvec_iter_advance_single() that is

Re: [PATCH 5.11] block: optimise for_each_bvec() advance

2020-11-24 Thread Ming Lei
On Tue, Nov 24, 2020 at 10:21:23AM +, Pavel Begunkov wrote: > Because of how for_each_bvec() works it never advances across multiple > entries at a time, so bvec_iter_advance() is an overkill. Add > specialised bvec_iter_advance_single() that is faster. It also handles > zero-len bvecs, so can

Re: [PATCH 5.11] block: optimise for_each_bvec() advance

2020-11-24 Thread Christoph Hellwig
On Tue, Nov 24, 2020 at 10:21:23AM +, Pavel Begunkov wrote: > Because of how for_each_bvec() works it never advances across multiple > entries at a time, so bvec_iter_advance() is an overkill. Add > specialised bvec_iter_advance_single() that is faster. It also handles > zero-len bvecs, so can

[PATCH 5.11] block: optimise for_each_bvec() advance

2020-11-24 Thread Pavel Begunkov
Because of how for_each_bvec() works it never advances across multiple entries at a time, so bvec_iter_advance() is an overkill. Add specialised bvec_iter_advance_single() that is faster. It also handles zero-len bvecs, so can kill bvec_iter_skip_zero_bvec(). textdata bss dec