Re: [PATCH 5.4 35/65] nfsd: clients dont need to break their own delegations

2020-07-07 Thread J. Bruce Fields
On Tue, Jul 07, 2020 at 01:29:30PM -0400, Sasha Levin wrote: > On Tue, Jul 07, 2020 at 01:20:51PM -0400, Sasha Levin wrote: > > On Tue, Jul 07, 2020 at 11:31:22AM -0400, J. Bruce Fields wrote: > > > NACK. > > > > > > (How did this one even end up headed for stable? It wasn't cc'd to > > > > It

Re: [PATCH 5.4 35/65] nfsd: clients dont need to break their own delegations

2020-07-07 Thread Sasha Levin
On Tue, Jul 07, 2020 at 01:20:51PM -0400, Sasha Levin wrote: On Tue, Jul 07, 2020 at 11:31:22AM -0400, J. Bruce Fields wrote: NACK. (How did this one even end up headed for stable? It wasn't cc'd to It came in when I was looking at the later nfs patches in this series and figured it is a

Re: [PATCH 5.4 35/65] nfsd: clients dont need to break their own delegations

2020-07-07 Thread Sasha Levin
On Tue, Jul 07, 2020 at 11:31:22AM -0400, J. Bruce Fields wrote: NACK. (How did this one even end up headed for stable? It wasn't cc'd to It came in when I was looking at the later nfs patches in this series and figured it is a fix on its own. stable, it's not a bugfix, and it's not a

[PATCH 5.4 35/65] nfsd: clients dont need to break their own delegations

2020-07-07 Thread Greg Kroah-Hartman
From: J. Bruce Fields [ Upstream commit 28df3d1539de5090f7916f6fff03891b67f366f4 ] We currently revoke read delegations on any write open or any operation that modifies file data or metadata (including rename, link, and unlink). But if the delegation in question is the only read delegation and

Re: [PATCH 5.4 35/65] nfsd: clients dont need to break their own delegations

2020-07-07 Thread J. Bruce Fields
NACK. (How did this one even end up headed for stable? It wasn't cc'd to stable, it's not a bugfix, and it's not a small patch.) --b. On Tue, Jul 07, 2020 at 05:17:14PM +0200, Greg Kroah-Hartman wrote: > From: J. Bruce Fields > > [ Upstream commit 28df3d1539de5090f7916f6fff03891b67f366f4 ] >