Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-27 Thread Atish Patra
On Thu, 2020-07-23 at 13:46 +0900, Stafford Horne wrote: > On Wed, Jul 22, 2020 at 03:11:35PM +, Atish Patra wrote: > > On Wed, 2020-07-22 at 14:48 +0200, Greg KH wrote: > > > On Tue, Jul 21, 2020 at 03:50:35PM -0700, Palmer Dabbelt wrote: > > > > On Mon, 20 Jul 2020 12:14:03 PDT (-0700), Greg

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-22 Thread Stafford Horne
On Wed, Jul 22, 2020 at 03:11:35PM +, Atish Patra wrote: > On Wed, 2020-07-22 at 14:48 +0200, Greg KH wrote: > > On Tue, Jul 21, 2020 at 03:50:35PM -0700, Palmer Dabbelt wrote: > > > On Mon, 20 Jul 2020 12:14:03 PDT (-0700), Greg KH wrote: > > > > On Mon, Jul 20, 2020 at 06:50:10PM +,

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-22 Thread Atish Patra
On Wed, 2020-07-22 at 14:48 +0200, Greg KH wrote: > On Tue, Jul 21, 2020 at 03:50:35PM -0700, Palmer Dabbelt wrote: > > On Mon, 20 Jul 2020 12:14:03 PDT (-0700), Greg KH wrote: > > > On Mon, Jul 20, 2020 at 06:50:10PM +, Atish Patra wrote: > > > > On Mon, 2020-07-20 at 23:11 +0530, Naresh

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-22 Thread Greg KH
On Tue, Jul 21, 2020 at 03:50:35PM -0700, Palmer Dabbelt wrote: > On Mon, 20 Jul 2020 12:14:03 PDT (-0700), Greg KH wrote: > > On Mon, Jul 20, 2020 at 06:50:10PM +, Atish Patra wrote: > > > On Mon, 2020-07-20 at 23:11 +0530, Naresh Kamboju wrote: > > > > RISC-V build breaks on stable-rc 5.7

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-21 Thread Palmer Dabbelt
On Mon, 20 Jul 2020 12:14:03 PDT (-0700), Greg KH wrote: On Mon, Jul 20, 2020 at 06:50:10PM +, Atish Patra wrote: On Mon, 2020-07-20 at 23:11 +0530, Naresh Kamboju wrote: > RISC-V build breaks on stable-rc 5.7 branch. > build failed with gcc-8, gcc-9 and gcc-9. > Sorry for the compilation

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-20 Thread gre...@linuxfoundation.org
On Mon, Jul 20, 2020 at 06:50:10PM +, Atish Patra wrote: > On Mon, 2020-07-20 at 23:11 +0530, Naresh Kamboju wrote: > > RISC-V build breaks on stable-rc 5.7 branch. > > build failed with gcc-8, gcc-9 and gcc-9. > > > > Sorry for the compilation issue. > > mmap_read_lock was intrdouced in

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-20 Thread Atish Patra
On Mon, 2020-07-20 at 23:11 +0530, Naresh Kamboju wrote: > RISC-V build breaks on stable-rc 5.7 branch. > build failed with gcc-8, gcc-9 and gcc-9. > Sorry for the compilation issue. mmap_read_lock was intrdouced in the following commit. commit 9740ca4e95b4 Author: Michel Lespinasse Date:

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-20 Thread Naresh Kamboju
RISC-V build breaks on stable-rc 5.7 branch. build failed with gcc-8, gcc-9 and gcc-9. On Mon, 20 Jul 2020 at 21:46, Greg Kroah-Hartman wrote: > > From: Atish Patra > > commit 0e2c09011d4de4161f615ff860a605a9186cf62a upstream. > > As per walk_page_range documentation, mmap lock should be

[PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-20 Thread Greg Kroah-Hartman
From: Atish Patra commit 0e2c09011d4de4161f615ff860a605a9186cf62a upstream. As per walk_page_range documentation, mmap lock should be acquired by the caller before invoking walk_page_range. mmap_assert_locked gets triggered without that. The details can be found here.