Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-08-08 Thread Paul Fulghum
Krzysztof Halasa wrote: Mariusz Kozlowski <[EMAIL PROTECTED]> writes: Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/n_hdlc.c | 27451 -> 27413 (-38 bytes) drivers/char/n_hdlc.o | 107068 -> 107088 (+20 bytes) BTW: drivers/char/n_hdlc is a very different thing than these

Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-08-08 Thread Krzysztof Halasa
Mariusz Kozlowski <[EMAIL PROTECTED]> writes: > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/char/n_hdlc.c | 27451 -> 27413 (-38 bytes) > drivers/char/n_hdlc.o | 107068 -> 107088 (+20 bytes) BTW: drivers/char/n_hdlc is a very different thing than these in drivers/net/wan/

Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-08-08 Thread Mariusz Kozlowski
> > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > NAK > > > - struct n_hdlc *n_hdlc = kmalloc(sizeof(*n_hdlc), GFP_KERNEL); > > - > > + struct n_hdlc *n_hdlc; > > + > > + n_hdlc = kzalloc(sizeof(*n_hdlc), GFP_KERNEL); > > Change looks fine but please keep the original

Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-08-08 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] NAK - struct n_hdlc *n_hdlc = kmalloc(sizeof(*n_hdlc), GFP_KERNEL); - + struct n_hdlc *n_hdlc; + + n_hdlc = kzalloc(sizeof(*n_hdlc), GFP_KERNEL); Change looks fine but please keep the original formatting style Ok. Here

Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-08-08 Thread Krzysztof Halasa
Mariusz Kozlowski [EMAIL PROTECTED] writes: Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] drivers/char/n_hdlc.c | 27451 - 27413 (-38 bytes) drivers/char/n_hdlc.o | 107068 - 107088 (+20 bytes) BTW: drivers/char/n_hdlc is a very different thing than these in drivers/net/wan/ and I have

Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-08-08 Thread Paul Fulghum
Krzysztof Halasa wrote: Mariusz Kozlowski [EMAIL PROTECTED] writes: Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] drivers/char/n_hdlc.c | 27451 - 27413 (-38 bytes) drivers/char/n_hdlc.o | 107068 - 107088 (+20 bytes) BTW: drivers/char/n_hdlc is a very different thing than these in

Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Alan Cox
On Tue, 31 Jul 2007 23:27:30 +0200 Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> NAK > - struct n_hdlc *n_hdlc = kmalloc(sizeof(*n_hdlc), GFP_KERNEL); > - > + struct n_hdlc *n_hdlc; > + > + n_hdlc = kzalloc(sizeof(*n_hdlc),

[PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/n_hdlc.c | 27451 -> 27423 (-28 bytes) drivers/char/n_hdlc.o | 112528 -> 112516 (-12 bytes) drivers/char/n_hdlc.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/char/n_hdlc.c

[PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] drivers/char/n_hdlc.c | 27451 - 27423 (-28 bytes) drivers/char/n_hdlc.o | 112528 - 112516 (-12 bytes) drivers/char/n_hdlc.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/char/n_hdlc.c

Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Alan Cox
On Tue, 31 Jul 2007 23:27:30 +0200 Mariusz Kozlowski [EMAIL PROTECTED] wrote: Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] NAK - struct n_hdlc *n_hdlc = kmalloc(sizeof(*n_hdlc), GFP_KERNEL); - + struct n_hdlc *n_hdlc; + + n_hdlc = kzalloc(sizeof(*n_hdlc), GFP_KERNEL);