Re: [PATCH 6/6] sunrpc: rework proc handlers to take advantage of the new buffer

On Thu, Aug 13, 2020 at 05:04:11PM -0400, Josef Bacik wrote: > + len = scnprintf(buffer, *lenp, "0x%04x\n", *(unsigned int *) > table->data); This adds a really hard to read overlong long line. Otherwise looks good: Reviewed-by: Christoph Hellwig

[PATCH 6/6] sunrpc: rework proc handlers to take advantage of the new buffer

Now that we're allocating an extra slot for the NULL terminated string, use scnprintf() and write directly into the buffer. Signed-off-by: Josef Bacik --- net/sunrpc/sysctl.c| 10 ++ net/sunrpc/xprtrdma/svc_rdma.c | 16 ++-- 2 files changed, 4 insertions(+), 22