Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe->nhit

2013-02-11 Thread Srikar Dronamraju
* Oleg Nesterov [2013-01-31 20:18:32]: > Move tu->nhit++ from uprobe_trace_func() to uprobe_dispatcher(). > > ->nhit counts how many time we hit the breakpoint inserted by this > uprobe, we do not want to loose this info if uprobe was enabled by > sys_perf_event_open(). > > Signed-off-by: Oleg

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe-nhit

2013-02-11 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2013-01-31 20:18:32]: Move tu-nhit++ from uprobe_trace_func() to uprobe_dispatcher(). -nhit counts how many time we hit the breakpoint inserted by this uprobe, we do not want to loose this info if uprobe was enabled by sys_perf_event_open().

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe->nhit

2013-02-04 Thread Steven Rostedt
On Mon, 2013-02-04 at 21:56 +0530, Srikar Dronamraju wrote: > * Oleg Nesterov [2013-02-04 16:18:50]: > > > On 02/04, Srikar Dronamraju wrote: > > > > > > * Oleg Nesterov [2013-01-31 20:18:32]: > > > > > > > Move tu->nhit++ from uprobe_trace_func() to uprobe_dispatcher(). > > > > > > > > ->nhit

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe->nhit

2013-02-04 Thread Srikar Dronamraju
* Oleg Nesterov [2013-02-04 16:18:50]: > On 02/04, Srikar Dronamraju wrote: > > > > * Oleg Nesterov [2013-01-31 20:18:32]: > > > > > Move tu->nhit++ from uprobe_trace_func() to uprobe_dispatcher(). > > > > > > ->nhit counts how many time we hit the breakpoint inserted by this > > > uprobe, we

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe->nhit

2013-02-04 Thread Oleg Nesterov
On 02/04, Srikar Dronamraju wrote: > > * Oleg Nesterov [2013-01-31 20:18:32]: > > > Move tu->nhit++ from uprobe_trace_func() to uprobe_dispatcher(). > > > > ->nhit counts how many time we hit the breakpoint inserted by this > > uprobe, we do not want to loose this info if uprobe was enabled by >

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe->nhit

2013-02-04 Thread Srikar Dronamraju
* Oleg Nesterov [2013-01-31 20:18:32]: > Move tu->nhit++ from uprobe_trace_func() to uprobe_dispatcher(). > > ->nhit counts how many time we hit the breakpoint inserted by this > uprobe, we do not want to loose this info if uprobe was enabled by > sys_perf_event_open(). > Though I dont see a

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe-nhit

2013-02-04 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2013-01-31 20:18:32]: Move tu-nhit++ from uprobe_trace_func() to uprobe_dispatcher(). -nhit counts how many time we hit the breakpoint inserted by this uprobe, we do not want to loose this info if uprobe was enabled by sys_perf_event_open(). Though I dont

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe-nhit

2013-02-04 Thread Oleg Nesterov
On 02/04, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2013-01-31 20:18:32]: Move tu-nhit++ from uprobe_trace_func() to uprobe_dispatcher(). -nhit counts how many time we hit the breakpoint inserted by this uprobe, we do not want to loose this info if uprobe was enabled by

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe-nhit

2013-02-04 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2013-02-04 16:18:50]: On 02/04, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2013-01-31 20:18:32]: Move tu-nhit++ from uprobe_trace_func() to uprobe_dispatcher(). -nhit counts how many time we hit the breakpoint inserted by this

Re: [PATCH 6/6] uprobes/perf: Always increment trace_uprobe-nhit

2013-02-04 Thread Steven Rostedt
On Mon, 2013-02-04 at 21:56 +0530, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2013-02-04 16:18:50]: On 02/04, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2013-01-31 20:18:32]: Move tu-nhit++ from uprobe_trace_func() to uprobe_dispatcher().

[PATCH 6/6] uprobes/perf: Always increment trace_uprobe->nhit

2013-01-31 Thread Oleg Nesterov
Move tu->nhit++ from uprobe_trace_func() to uprobe_dispatcher(). ->nhit counts how many time we hit the breakpoint inserted by this uprobe, we do not want to loose this info if uprobe was enabled by sys_perf_event_open(). Signed-off-by: Oleg Nesterov --- kernel/trace/trace_uprobe.c |3 +--

[PATCH 6/6] uprobes/perf: Always increment trace_uprobe-nhit

2013-01-31 Thread Oleg Nesterov
Move tu-nhit++ from uprobe_trace_func() to uprobe_dispatcher(). -nhit counts how many time we hit the breakpoint inserted by this uprobe, we do not want to loose this info if uprobe was enabled by sys_perf_event_open(). Signed-off-by: Oleg Nesterov o...@redhat.com ---