Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-09 Thread Steven Rostedt
On Sun, 8 Feb 2015 23:12:46 +0900 Namhyung Kim wrote: > Shouldn't it be /sys/kernel/tracing/ ? > > if (evsel == NULL) { > > - pr_debug("is debugfs mounted on /sys/kernel/debug?\n"); > > + if (tracefs_configured()) > > + pr_debug("is tracefs mounted on

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-09 Thread Steven Rostedt
On Sun, 8 Feb 2015 23:12:46 +0900 Namhyung Kim namhy...@kernel.org wrote: Shouldn't it be /sys/kernel/tracing/ ? if (evsel == NULL) { - pr_debug(is debugfs mounted on /sys/kernel/debug?\n); + if (tracefs_configured()) + pr_debug(is tracefs

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-08 Thread Namhyung Kim
Hi Steve, On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > As tracefs may be mounted instead of debugfs to get to the event directories, > have perf know about tracefs, and use that file system over debugfs if it > is present. > >

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-08 Thread Namhyung Kim
Hi Steve, On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org As tracefs may be mounted instead of debugfs to get to the event directories, have perf know about tracefs, and use that file system over debugfs if it is present.

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-06 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 03, 2015 at 11:45:50AM -0500, Steven Rostedt escreveu: > On Tue, 3 Feb 2015 15:16:25 +0100 > Jiri Olsa wrote: > > I guess you ommited the fprint(stderr... ) warning on purpose > > (like in find_debugfs), because the tracefs is not upstream yet, right? > Right, because I didn't want

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-06 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 03, 2015 at 11:45:50AM -0500, Steven Rostedt escreveu: On Tue, 3 Feb 2015 15:16:25 +0100 Jiri Olsa jo...@redhat.com wrote: I guess you ommited the fprint(stderr... ) warning on purpose (like in find_debugfs), because the tracefs is not upstream yet, right? Right, because I

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-03 Thread Steven Rostedt
On Tue, 3 Feb 2015 15:16:25 +0100 Jiri Olsa wrote: > On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: > > SNIP > > > } > > @@ -325,12 +351,19 @@ const char *perf_debugfs_mount(const char *mountpoint) > > void perf_debugfs_set_path(const char *mntpt) > > { > >

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-03 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: SNIP > } > @@ -325,12 +351,19 @@ const char *perf_debugfs_mount(const char *mountpoint) > void perf_debugfs_set_path(const char *mntpt) > { > snprintf(debugfs_mountpoint, strlen(debugfs_mountpoint), "%s", mntpt); > -

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-03 Thread Steven Rostedt
On Tue, 3 Feb 2015 15:16:25 +0100 Jiri Olsa jo...@redhat.com wrote: On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: SNIP } @@ -325,12 +351,19 @@ const char *perf_debugfs_mount(const char *mountpoint) void perf_debugfs_set_path(const char *mntpt) {

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-03 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: SNIP } @@ -325,12 +351,19 @@ const char *perf_debugfs_mount(const char *mountpoint) void perf_debugfs_set_path(const char *mntpt) { snprintf(debugfs_mountpoint, strlen(debugfs_mountpoint), %s, mntpt); -

[PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-02 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" As tracefs may be mounted instead of debugfs to get to the event directories, have perf know about tracefs, and use that file system over debugfs if it is present. Signed-off-by: Steven Rostedt --- tools/perf/tests/open-syscall-all-cpus.c | 7 +++-

[PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-02 Thread Steven Rostedt
From: Steven Rostedt (Red Hat) rost...@goodmis.org As tracefs may be mounted instead of debugfs to get to the event directories, have perf know about tracefs, and use that file system over debugfs if it is present. Signed-off-by: Steven Rostedt rost...@goodmis.org ---