Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Chase Southwood
Hartley, Yes, you raise very good points. In any case, I have added cover letters to my submitting checklist so hopefully everything will be a lot easier for everyone next go round. Thanks, Chase On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten wrote: > On Wednesday, April 30, 2014 12:52 AM,

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Hartley Sweeten
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: > Thanks so much, I greatly appreciate the review. I'll fix the > changelog for patch 4 and send once more (as I assume that's easier > for Greg). Also, I should know better about the cover letter as > well...I was once told not to

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Chase Southwood
Ian and Hartley, Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them for strictly cleanup patchsets (as Greg

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Chase Southwood
Ian and Hartley, Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them for strictly cleanup patchsets (as Greg

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Hartley Sweeten
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Chase Southwood
Hartley, Yes, you raise very good points. In any case, I have added cover letters to my submitting checklist so hopefully everything will be a lot easier for everyone next go round. Thanks, Chase On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten hartl...@visionengravers.com wrote: On

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-29 Thread Hartley Sweeten
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: > This driver no longer reads the eeprom to find the board specific data, > all the necessary data is in the boardinfo. Use the boardinfo directly > instead of passing through devpriv->s_EeParameters. > > Signed-off-by: Chase Southwood

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-29 Thread Ian Abbott
On 2014-04-29 09:38, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv->s_EeParameters. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H

[PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-29 Thread Chase Southwood
This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv->s_EeParameters. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- 2: Incorrect patch title

[PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-29 Thread Chase Southwood
This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-29 Thread Ian Abbott
On 2014-04-29 09:38, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood chase.southw...@gmail.com

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-29 Thread Hartley Sweeten
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood