Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Joe Perches
On Wed, 2014-06-11 at 02:23 +0200, Rafael J. Wysocki wrote: > On Tuesday, June 10, 2014 02:26:45 PM Joe Perches wrote: > > c89 is 25 years ago now. > Apparently, I'm old. nah, just older than yesterday. No doubt better too. > > > Either way, in my opinion it's better to put the parens into the

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Wednesday, June 11, 2014 12:35:25 AM Stratos Karafotis wrote: > On 11/06/2014 12:38 πμ, Rafael J. Wysocki wrote: > > On Wednesday, June 11, 2014 12:02:09 AM Stratos Karafotis wrote: > >> On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: > >>> On Tuesday, June 10, 2014 11:14:53 PM Stratos

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 02:26:45 PM Joe Perches wrote: > On Tue, 2014-06-10 at 23:38 +0200, Rafael J. Wysocki wrote: > > > > > is. And the result of (a * 100) / b may generally be different from > > > > a * 100 / b for integers (if the division is carried out first). > > > > > > I thought

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 11/06/2014 12:38 πμ, Rafael J. Wysocki wrote: > On Wednesday, June 11, 2014 12:02:09 AM Stratos Karafotis wrote: >> On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: >>> On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: > On

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Joe Perches
On Tue, 2014-06-10 at 23:38 +0200, Rafael J. Wysocki wrote: > > > is. And the result of (a * 100) / b may generally be different from > > > a * 100 / b for integers (if the division is carried out first). > > > > I thought that (a * 100) / b is always equivalent to a * 100 / b. > > I'm not

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Wednesday, June 11, 2014 12:02:09 AM Stratos Karafotis wrote: > On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: > > On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: > >> On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: > >>> On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: > On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: >> On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: >>> On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: > On

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: > On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: > > On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: > >> On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: > >>> On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote:

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: > On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: >> On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: >>> On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: On 06/09/2014 02:01 PM, Stratos Karafotis wrote: > Remove

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: > On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: > > On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: > >> On 06/09/2014 02:01 PM, Stratos Karafotis wrote: > >>> Remove unnecessary blank lines. > >>> Remove unnecessary

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Dirk Brandewie
On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: On 06/09/2014 02:01 PM, Stratos Karafotis wrote: Remove unnecessary blank lines. Remove unnecessary parentheses. Remove unnecessary braces. Put the code in one line where possible. Add

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: > On 06/09/2014 02:01 PM, Stratos Karafotis wrote: > > Remove unnecessary blank lines. > > Remove unnecessary parentheses. > > Remove unnecessary braces. > > Put the code in one line where possible. > > Add blank lines after variable

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Dirk Brandewie
On 06/09/2014 02:01 PM, Stratos Karafotis wrote: Remove unnecessary blank lines. Remove unnecessary parentheses. Remove unnecessary braces. Put the code in one line where possible. Add blank lines after variable declarations. Alignment to open parenthesis. I don't have an issue with this

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 10/06/2014 12:22 πμ, Joe Perches wrote: > On Tue, 2014-06-10 at 00:01 +0300, Stratos Karafotis wrote: >> Remove unnecessary braces. > > [] > >> @@ -204,20 +203,16 @@ static inline void intel_pstate_busy_pid_reset(struct >> cpudata *cpu) > >> static inline void

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 10/06/2014 12:22 πμ, Joe Perches wrote: On Tue, 2014-06-10 at 00:01 +0300, Stratos Karafotis wrote: Remove unnecessary braces. [] @@ -204,20 +203,16 @@ static inline void intel_pstate_busy_pid_reset(struct cpudata *cpu) static inline void intel_pstate_reset_all_pid(void) {

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Dirk Brandewie
On 06/09/2014 02:01 PM, Stratos Karafotis wrote: Remove unnecessary blank lines. Remove unnecessary parentheses. Remove unnecessary braces. Put the code in one line where possible. Add blank lines after variable declarations. Alignment to open parenthesis. I don't have an issue with this

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: On 06/09/2014 02:01 PM, Stratos Karafotis wrote: Remove unnecessary blank lines. Remove unnecessary parentheses. Remove unnecessary braces. Put the code in one line where possible. Add blank lines after variable declarations.

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Dirk Brandewie
On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: On 06/09/2014 02:01 PM, Stratos Karafotis wrote: Remove unnecessary blank lines. Remove unnecessary parentheses. Remove unnecessary braces. Put the code in one line where possible. Add

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: On 06/09/2014 02:01 PM, Stratos Karafotis wrote: Remove unnecessary blank lines. Remove unnecessary parentheses.

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: On 06/09/2014 02:01 PM, Stratos Karafotis wrote: Remove unnecessary blank

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: On

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: On Tuesday, June 10,

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Wednesday, June 11, 2014 12:02:09 AM Stratos Karafotis wrote: On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 10:26:44 AM Dirk Brandewie wrote: On

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Joe Perches
On Tue, 2014-06-10 at 23:38 +0200, Rafael J. Wysocki wrote: is. And the result of (a * 100) / b may generally be different from a * 100 / b for integers (if the division is carried out first). I thought that (a * 100) / b is always equivalent to a * 100 / b. I'm not actually sure

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Stratos Karafotis
On 11/06/2014 12:38 πμ, Rafael J. Wysocki wrote: On Wednesday, June 11, 2014 12:02:09 AM Stratos Karafotis wrote: On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote: On 10/06/2014 11:17 μμ, Rafael J. Wysocki wrote: On Tuesday, June

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Tuesday, June 10, 2014 02:26:45 PM Joe Perches wrote: On Tue, 2014-06-10 at 23:38 +0200, Rafael J. Wysocki wrote: is. And the result of (a * 100) / b may generally be different from a * 100 / b for integers (if the division is carried out first). I thought that (a * 100) / b

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Rafael J. Wysocki
On Wednesday, June 11, 2014 12:35:25 AM Stratos Karafotis wrote: On 11/06/2014 12:38 πμ, Rafael J. Wysocki wrote: On Wednesday, June 11, 2014 12:02:09 AM Stratos Karafotis wrote: On 10/06/2014 11:43 μμ, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 11:14:53 PM Stratos Karafotis wrote:

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-10 Thread Joe Perches
On Wed, 2014-06-11 at 02:23 +0200, Rafael J. Wysocki wrote: On Tuesday, June 10, 2014 02:26:45 PM Joe Perches wrote: c89 is 25 years ago now. Apparently, I'm old. nah, just older than yesterday. No doubt better too. Either way, in my opinion it's better to put the parens into the

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-09 Thread Joe Perches
On Tue, 2014-06-10 at 00:01 +0300, Stratos Karafotis wrote: > Remove unnecessary braces. [] > @@ -204,20 +203,16 @@ static inline void intel_pstate_busy_pid_reset(struct > cpudata *cpu) > static inline void intel_pstate_reset_all_pid(void) > { > unsigned int cpu; > -

[PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-09 Thread Stratos Karafotis
Remove unnecessary blank lines. Remove unnecessary parentheses. Remove unnecessary braces. Put the code in one line where possible. Add blank lines after variable declarations. Alignment to open parenthesis. Signed-off-by: Stratos Karafotis --- drivers/cpufreq/intel_pstate.c | 96

[PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-09 Thread Stratos Karafotis
Remove unnecessary blank lines. Remove unnecessary parentheses. Remove unnecessary braces. Put the code in one line where possible. Add blank lines after variable declarations. Alignment to open parenthesis. Signed-off-by: Stratos Karafotis strat...@semaphore.gr ---

Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

2014-06-09 Thread Joe Perches
On Tue, 2014-06-10 at 00:01 +0300, Stratos Karafotis wrote: Remove unnecessary braces. [] @@ -204,20 +203,16 @@ static inline void intel_pstate_busy_pid_reset(struct cpudata *cpu) static inline void intel_pstate_reset_all_pid(void) { unsigned int cpu; -