Re: [PATCH 6/7] mm: Pass pvec directly to find_get_entries

2020-08-25 Thread Johannes Weiner
On Tue, Aug 25, 2020 at 02:28:14PM +0100, Matthew Wilcox wrote: > On Tue, Aug 25, 2020 at 02:33:24PM +0200, Jan Kara wrote: > > On Mon 24-08-20 18:36:39, Matthew Wilcox wrote: > > > We already have functions in filemap which take a pagevec, eg > > > page_cache_delete_batch() and

Re: [PATCH 6/7] mm: Pass pvec directly to find_get_entries

2020-08-25 Thread Jan Kara
On Tue 25-08-20 14:28:14, Matthew Wilcox wrote: > On Tue, Aug 25, 2020 at 02:33:24PM +0200, Jan Kara wrote: > > On Mon 24-08-20 18:36:39, Matthew Wilcox wrote: > > > We already have functions in filemap which take a pagevec, eg > > > page_cache_delete_batch() and delete_from_page_cache_batch(). >

Re: [PATCH 6/7] mm: Pass pvec directly to find_get_entries

2020-08-25 Thread Matthew Wilcox
On Tue, Aug 25, 2020 at 02:33:24PM +0200, Jan Kara wrote: > On Mon 24-08-20 18:36:39, Matthew Wilcox wrote: > > We already have functions in filemap which take a pagevec, eg > > page_cache_delete_batch() and delete_from_page_cache_batch(). > > Right but those are really pretty internal helper

Re: [PATCH 6/7] mm: Pass pvec directly to find_get_entries

2020-08-25 Thread Jan Kara
On Mon 24-08-20 18:36:39, Matthew Wilcox wrote: > On Mon, Aug 24, 2020 at 06:16:20PM +0200, Jan Kara wrote: > > On Wed 19-08-20 16:05:54, Matthew Wilcox (Oracle) wrote: > > > All callers of find_get_entries() use a pvec, so pass it directly > > > instead of manipulating it in the caller. > > > >

Re: [PATCH 6/7] mm: Pass pvec directly to find_get_entries

2020-08-24 Thread Matthew Wilcox
On Mon, Aug 24, 2020 at 06:16:20PM +0200, Jan Kara wrote: > On Wed 19-08-20 16:05:54, Matthew Wilcox (Oracle) wrote: > > All callers of find_get_entries() use a pvec, so pass it directly > > instead of manipulating it in the caller. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Rather than

Re: [PATCH 6/7] mm: Pass pvec directly to find_get_entries

2020-08-24 Thread Jan Kara
On Wed 19-08-20 16:05:54, Matthew Wilcox (Oracle) wrote: > All callers of find_get_entries() use a pvec, so pass it directly > instead of manipulating it in the caller. > > Signed-off-by: Matthew Wilcox (Oracle) Rather than passing pvec to find_get_entries() and then making everybody use it,

[PATCH 6/7] mm: Pass pvec directly to find_get_entries

2020-08-19 Thread Matthew Wilcox (Oracle)
All callers of find_get_entries() use a pvec, so pass it directly instead of manipulating it in the caller. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 3 +-- mm/filemap.c| 14 ++ mm/shmem.c | 11 +++ mm/swap.c