Re: [PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-20 Thread Peter Zijlstra
On Mon, Jan 20, 2014 at 02:02:32PM -0500, Rik van Riel wrote: > That is what I started out with, and the results were not > as stable as with this calculation. > > Having said that, I did that before I came up with patch 7/7, > so maybe the effect would no longer be as pronounced any more > as it

Re: [PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-20 Thread Rik van Riel
On 01/20/2014 11:57 AM, Peter Zijlstra wrote: > On Fri, Jan 17, 2014 at 04:12:08PM -0500, r...@redhat.com wrote: >> diff --git a/include/linux/sched.h b/include/linux/sched.h >> index 0af6c1a..52de567 100644 >> --- a/include/linux/sched.h >> +++ b/include/linux/sched.h >> @@ -1471,6 +1471,8 @@

Re: [PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-20 Thread Peter Zijlstra
On Fri, Jan 17, 2014 at 04:12:08PM -0500, r...@redhat.com wrote: > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 0af6c1a..52de567 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1471,6 +1471,8 @@ struct task_struct { > int numa_preferred_nid; >

Re: [PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-20 Thread Peter Zijlstra
On Fri, Jan 17, 2014 at 04:12:08PM -0500, r...@redhat.com wrote: diff --git a/include/linux/sched.h b/include/linux/sched.h index 0af6c1a..52de567 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1471,6 +1471,8 @@ struct task_struct { int numa_preferred_nid;

Re: [PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-20 Thread Rik van Riel
On 01/20/2014 11:57 AM, Peter Zijlstra wrote: On Fri, Jan 17, 2014 at 04:12:08PM -0500, r...@redhat.com wrote: diff --git a/include/linux/sched.h b/include/linux/sched.h index 0af6c1a..52de567 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1471,6 +1471,8 @@ struct

Re: [PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-20 Thread Peter Zijlstra
On Mon, Jan 20, 2014 at 02:02:32PM -0500, Rik van Riel wrote: That is what I started out with, and the results were not as stable as with this calculation. Having said that, I did that before I came up with patch 7/7, so maybe the effect would no longer be as pronounced any more as it was

[PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-17 Thread riel
From: Rik van Riel The tracepoint has made it abundantly clear that the naive implementation of the faults_from code has issues. Specifically, the garbage collector in some workloads will access orders of magnitudes more memory than the threads that do all the active work. This resulted in the

[PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use

2014-01-17 Thread riel
From: Rik van Riel r...@redhat.com The tracepoint has made it abundantly clear that the naive implementation of the faults_from code has issues. Specifically, the garbage collector in some workloads will access orders of magnitudes more memory than the threads that do all the active work. This