RE: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-10-14 Thread Shivamurthy Shastri (sshivamurthy)
Hi Boris, Thank you for the review. > > On Mon, 19 Aug 2019 09:03:38 + > "Shivamurthy Shastri (sshivamurthy)" wrote: > > > > > > > > static int micron_spinand_detect(struct spinand_device *spinand) > > > > { > > > > + const struct spi_mem_op *op; > > > > u8 *id = spinand->i

Re: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-10-07 Thread Boris Brezillon
On Mon, 19 Aug 2019 09:03:38 + "Shivamurthy Shastri (sshivamurthy)" wrote: > > > > > static int micron_spinand_detect(struct spinand_device *spinand) > > > { > > > + const struct spi_mem_op *op; > > > u8 *id = spinand->id.data; > > > - int ret; > > > > > > /* > > >* Micron SPI NA

RE: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-09-16 Thread Shivamurthy Shastri (sshivamurthy)
Hello Miquel & Boris, Just a gentle reminder that I'd like some feedback. Thanks, Shiva > > Hi Boris, > > I need your opinion on the question below. > > "Shivamurthy Shastri (sshivamurthy)" wrote > on > Mon, 19 Aug 2019 09:03:38 +: > > > Hi Miquel, > > > > > > > > Hi Shiva, > > > > > >

Re: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-08-19 Thread Miquel Raynal
Hi Boris, I need your opinion on the question below. "Shivamurthy Shastri (sshivamurthy)" wrote on Mon, 19 Aug 2019 09:03:38 +: > Hi Miquel, > > > > > Hi Shiva, > > > > shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:19 +0200: > > > > > From: Shivamurthy Shastri > > > >

RE: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-08-19 Thread Shivamurthy Shastri (sshivamurthy)
Hi Miquel, > > Hi Shiva, > > shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:19 +0200: > > > From: Shivamurthy Shastri > > > > I am not sure the "turn implemenatation generic" title describes what > you do. > > > Driver is redesigned using parameter page to support Micron SPI NAND

Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-08-07 Thread Miquel Raynal
Hi Shiva, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:19 +0200: > From: Shivamurthy Shastri > I am not sure the "turn implemenatation generic" title describes what you do. > Driver is redesigned using parameter page to support Micron SPI NAND > flashes. Redesigned is perhaps a

[PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-07-21 Thread shiva . linuxworks
From: Shivamurthy Shastri Driver is redesigned using parameter page to support Micron SPI NAND flashes. The reason why spinand_select_op_variant globalized is that the Micron driver no longer calling spinand_match_and_init. Signed-off-by: Shivamurthy Shastri --- drivers/mtd/nand/spi/core.c |