Re: [PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-16 Thread Wei Yang
On Mon, Dec 16, 2013 at 05:05:05PM +0800, Yijing Wang wrote: >On 2013/12/16 15:13, Wei Yang wrote: >> Yijing, >> >> This one looks good. >> >> While I take a look at the source code, there are around 20 places with >> similar style. Do you think it would be good to change all these places >> in

Re: [PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-16 Thread Yijing Wang
On 2013/12/16 15:13, Wei Yang wrote: > Yijing, > > This one looks good. > > While I take a look at the source code, there are around 20 places with > similar style. Do you think it would be good to change all these places > in one patch? I sent the other similar changes to related maillist,

Re: [PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-16 Thread Yijing Wang
On 2013/12/16 15:13, Wei Yang wrote: Yijing, This one looks good. While I take a look at the source code, there are around 20 places with similar style. Do you think it would be good to change all these places in one patch? I sent the other similar changes to related maillist, some of

Re: [PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-16 Thread Wei Yang
On Mon, Dec 16, 2013 at 05:05:05PM +0800, Yijing Wang wrote: On 2013/12/16 15:13, Wei Yang wrote: Yijing, This one looks good. While I take a look at the source code, there are around 20 places with similar style. Do you think it would be good to change all these places in one patch? I

Re: [PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-15 Thread Wei Yang
Yijing, This one looks good. While I take a look at the source code, there are around 20 places with similar style. Do you think it would be good to change all these places in one patch? On Thu, Dec 05, 2013 at 08:01:20PM +0800, Yijing Wang wrote: >Use PCI standard marco dev_is_pci() instead of

Re: [PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-15 Thread Wei Yang
Yijing, This one looks good. While I take a look at the source code, there are around 20 places with similar style. Do you think it would be good to change all these places in one patch? On Thu, Dec 05, 2013 at 08:01:20PM +0800, Yijing Wang wrote: Use PCI standard marco dev_is_pci() instead of

[PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-05 Thread Yijing Wang
Use PCI standard marco dev_is_pci() instead of directly compare pci_bus_type to check whether it is pci device. Signed-off-by: Yijing Wang --- arch/powerpc/sysdev/fsl_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_pci.c

[PATCH 6/9] powerpc/pci: Use dev_is_pci() to check whether it is pci device

2013-12-05 Thread Yijing Wang
Use PCI standard marco dev_is_pci() instead of directly compare pci_bus_type to check whether it is pci device. Signed-off-by: Yijing Wang wangyij...@huawei.com --- arch/powerpc/sysdev/fsl_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git