1. In order to remove duplicate code, following functions:
platform_get_resource
devm_kzalloc
devm_ioremap_resource
devm_clk_get
platform_get_irq
are replaced with a macro devm_platform_probe_helper.

2. This patch depends on the file include/linux/probe-helper.h
which is pushed in previous patch [01/09].

Signed-off-by: Satendra Singh Thakur <satendrasingh.tha...@hcl.com>
Signed-off-by: Satendra Singh Thakur <sst2...@gmail.com>
---
 drivers/dma/sun6i-dma.c | 30 +++++++++---------------------
 1 file changed, 9 insertions(+), 21 deletions(-)

diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index ed5b68dcfe50..41ee054bbeeb 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -19,6 +19,7 @@
 #include <linux/reset.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/probe-helper.h>
 
 #include "virt-dma.h"
 
@@ -1234,34 +1235,21 @@ static int sun6i_dma_probe(struct platform_device *pdev)
 {
        struct device_node *np = pdev->dev.of_node;
        struct sun6i_dma_dev *sdc;
-       struct resource *res;
        int ret, i;
 
-       sdc = devm_kzalloc(&pdev->dev, sizeof(*sdc), GFP_KERNEL);
-       if (!sdc)
-               return -ENOMEM;
+       /*
+        * This macro internally combines following functions:
+        * devm_kzalloc, platform_get_resource, devm_ioremap_resource,
+        * devm_clk_get, platform_get_irq
+        */
+       ret = devm_platform_probe_helper(pdev, sdc, NULL);
+       if (ret < 0)
+               return ret;
 
        sdc->cfg = of_device_get_match_data(&pdev->dev);
        if (!sdc->cfg)
                return -ENODEV;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       sdc->base = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(sdc->base))
-               return PTR_ERR(sdc->base);
-
-       sdc->irq = platform_get_irq(pdev, 0);
-       if (sdc->irq < 0) {
-               dev_err(&pdev->dev, "Cannot claim IRQ\n");
-               return sdc->irq;
-       }
-
-       sdc->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(sdc->clk)) {
-               dev_err(&pdev->dev, "No clock specified\n");
-               return PTR_ERR(sdc->clk);
-       }
-
        if (sdc->cfg->has_mbus_clk) {
                sdc->clk_mbus = devm_clk_get(&pdev->dev, "mbus");
                if (IS_ERR(sdc->clk_mbus)) {
-- 
2.17.1

Reply via email to