Re: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-28 Thread Kees Cook
On Tue, Aug 20, 2019 at 09:14:29PM -0400, Steven Rostedt wrote: > On Tue, 20 Aug 2019 12:58:49 +0200 > Christophe Leroy wrote: > > > >> index 1077366f496b..6c22e8a6f9de 100644 > > >> --- a/lib/bug.c > > >> +++ b/lib/bug.c > > >> @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long >

Re: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Steven Rostedt
On Tue, 20 Aug 2019 12:58:49 +0200 Christophe Leroy wrote: > >> index 1077366f496b..6c22e8a6f9de 100644 > >> --- a/lib/bug.c > >> +++ b/lib/bug.c > >> @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long bugaddr, > >> struct pt_regs *regs) > >>} > >>} > >> > >> +

Re: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Steven Rostedt
On Tue, 20 Aug 2019 09:33:24 -0700 Kees Cook wrote: > > > > diff --git a/lib/bug.c b/lib/bug.c > > > > index 1077366f496b..6c22e8a6f9de 100644 > > > > --- a/lib/bug.c > > > > +++ b/lib/bug.c > > > > @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long > > > > bugaddr, struct pt_regs

Re: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Kees Cook
On Tue, Aug 20, 2019 at 12:58:49PM +0200, Christophe Leroy wrote: > Le 20/08/2019 à 12:06, Peter Zijlstra a écrit : > > On Mon, Aug 19, 2019 at 04:41:11PM -0700, Kees Cook wrote: > > > > > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > > > index 588dd59a5b72..da471fcc5487

Re: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Christophe Leroy
Le 20/08/2019 à 12:06, Peter Zijlstra a écrit : On Mon, Aug 19, 2019 at 04:41:11PM -0700, Kees Cook wrote: diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h index 588dd59a5b72..da471fcc5487 100644 --- a/include/asm-generic/bug.h +++ b/include/asm-generic/bug.h @@ -10,6

Re: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Peter Zijlstra
On Mon, Aug 19, 2019 at 04:41:11PM -0700, Kees Cook wrote: > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > index 588dd59a5b72..da471fcc5487 100644 > --- a/include/asm-generic/bug.h > +++ b/include/asm-generic/bug.h > @@ -10,6 +10,7 @@ > #define BUGFLAG_WARNING

[PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-19 Thread Kees Cook
The original clean up of "cut here" missed the WARN_ON() case (that does not have a printk message), which was fixed recently by adding an explicit printk of "cut here". This had the downside of adding a printk() to every WARN_ON() caller, which reduces the utility of using an instruction