Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-03-05 Thread Tom Lendacky
On 2/28/2018 4:28 AM, Borislav Petkov wrote: > From: Ashok Raj > > Original idea by Ashok, completely rewritten by Borislav. > > Before you read any further: the early loading method is still the > preferred one and you should always do that. The following patch is >

Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-03-05 Thread Tom Lendacky
On 2/28/2018 4:28 AM, Borislav Petkov wrote: > From: Ashok Raj > > Original idea by Ashok, completely rewritten by Borislav. > > Before you read any further: the early loading method is still the > preferred one and you should always do that. The following patch is > improving the late loading

Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Henrique de Moraes Holschuh
On Wed, 28 Feb 2018, Borislav Petkov wrote: > On Wed, Feb 28, 2018 at 10:59:31AM -0300, Henrique de Moraes Holschuh wrote: > > Eek! If I read that right, this effectively halts the entire box until > > every core is updated, with one core entering deep-coma at a time (the > > rest are left either

Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Henrique de Moraes Holschuh
On Wed, 28 Feb 2018, Borislav Petkov wrote: > On Wed, Feb 28, 2018 at 10:59:31AM -0300, Henrique de Moraes Holschuh wrote: > > Eek! If I read that right, this effectively halts the entire box until > > every core is updated, with one core entering deep-coma at a time (the > > rest are left either

Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Borislav Petkov
On Wed, Feb 28, 2018 at 10:59:31AM -0300, Henrique de Moraes Holschuh wrote: > Eek! If I read that right, this effectively halts the entire box until > every core is updated, with one core entering deep-coma at a time (the > rest are left either spinning or cpu_relax()ing I think *you* should

Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Borislav Petkov
On Wed, Feb 28, 2018 at 10:59:31AM -0300, Henrique de Moraes Holschuh wrote: > Eek! If I read that right, this effectively halts the entire box until > every core is updated, with one core entering deep-coma at a time (the > rest are left either spinning or cpu_relax()ing I think *you* should

Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Henrique de Moraes Holschuh
On Wed, 28 Feb 2018, Borislav Petkov wrote: > + * Late loading dance. Why the heavy-handed stomp_machine effort? > + * > + * - HT siblings must be idle and not execute other code while the other > sibling > + * is loading microcode in order to avoid any negative interactions caused > by > + *

Re: [PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Henrique de Moraes Holschuh
On Wed, 28 Feb 2018, Borislav Petkov wrote: > + * Late loading dance. Why the heavy-handed stomp_machine effort? > + * > + * - HT siblings must be idle and not execute other code while the other > sibling > + * is loading microcode in order to avoid any negative interactions caused > by > + *

[PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Borislav Petkov
From: Ashok Raj Original idea by Ashok, completely rewritten by Borislav. Before you read any further: the early loading method is still the preferred one and you should always do that. The following patch is improving the late loading mechanism for long running jobs and

[PATCH 7/7] x86/microcode: Synchronize late microcode loading

2018-02-28 Thread Borislav Petkov
From: Ashok Raj Original idea by Ashok, completely rewritten by Borislav. Before you read any further: the early loading method is still the preferred one and you should always do that. The following patch is improving the late loading mechanism for long running jobs and cloud use cases.