Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-20 Thread Bo Shen
Hi Mark Brown, On 03/20/2014 09:47 PM, Mark Brown wrote: On Thu, Mar 20, 2014 at 10:37:53AM +0800, Bo Shen wrote: For this, in my mind, I think we need add following parameters in DT. 1. sysclk_src_from_fll --> we need do nothing. No, how would this work? If nothing else the FLL needs

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-20 Thread Mark Brown
On Thu, Mar 20, 2014 at 10:37:53AM +0800, Bo Shen wrote: > For this, in my mind, I think we need add following parameters in DT. > 1. sysclk_src_from_fll --> we need do nothing. No, how would this work? If nothing else the FLL needs configuration. > 2. sysclk_src_from_mclk >2.1

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-20 Thread Mark Brown
On Thu, Mar 20, 2014 at 10:37:53AM +0800, Bo Shen wrote: For this, in my mind, I think we need add following parameters in DT. 1. sysclk_src_from_fll -- we need do nothing. No, how would this work? If nothing else the FLL needs configuration. 2. sysclk_src_from_mclk 2.1

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-20 Thread Bo Shen
Hi Mark Brown, On 03/20/2014 09:47 PM, Mark Brown wrote: On Thu, Mar 20, 2014 at 10:37:53AM +0800, Bo Shen wrote: For this, in my mind, I think we need add following parameters in DT. 1. sysclk_src_from_fll -- we need do nothing. No, how would this work? If nothing else the FLL needs

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-19 Thread Bo Shen
Hi Mark, On 03/19/2014 06:28 PM, Mark Brown wrote: On Wed, Mar 19, 2014 at 01:57:23PM +0800, Bo Shen wrote: On 03/17/2014 07:55 PM, Mark Brown wrote: If this is a clock for the CODEC it should be documented as part of the binding for the CODEC and connected to the CODEC in the device tree

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-19 Thread Mark Brown
On Wed, Mar 19, 2014 at 01:57:23PM +0800, Bo Shen wrote: > On 03/17/2014 07:55 PM, Mark Brown wrote: > >If this is a clock for the CODEC it should be documented as part of the > >binding for the CODEC and connected to the CODEC in the device tree > >rather than being part of a machine driver

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-19 Thread Mark Brown
On Wed, Mar 19, 2014 at 01:57:23PM +0800, Bo Shen wrote: On 03/17/2014 07:55 PM, Mark Brown wrote: If this is a clock for the CODEC it should be documented as part of the binding for the CODEC and connected to the CODEC in the device tree rather than being part of a machine driver binding.

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-19 Thread Bo Shen
Hi Mark, On 03/19/2014 06:28 PM, Mark Brown wrote: On Wed, Mar 19, 2014 at 01:57:23PM +0800, Bo Shen wrote: On 03/17/2014 07:55 PM, Mark Brown wrote: If this is a clock for the CODEC it should be documented as part of the binding for the CODEC and connected to the CODEC in the device tree

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-18 Thread Bo Shen
Hi Mark, On 03/17/2014 07:55 PM, Mark Brown wrote: On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: - compatible: "atmel,asoc-wm8904" - atmel,model: The user-visible name of this sound complex. + - clocks: A list of clocks needed by the wm8904 chip. + - clock-output-names:

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-18 Thread Bo Shen
Hi Mark, On 03/17/2014 07:55 PM, Mark Brown wrote: On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: - compatible: atmel,asoc-wm8904 - atmel,model: The user-visible name of this sound complex. + - clocks: A list of clocks needed by the wm8904 chip. + - clock-output-names:

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Brown
On Mon, Mar 17, 2014 at 02:44:00PM +0100, Boris BREZILLON wrote: > Le 17/03/2014 12:55, Mark Brown a écrit : > >On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: > >If this is a clock for the CODEC it should be documented as part of the > >binding for the CODEC and connected to the CODEC

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread boris brezillon
Hello Mark, Le 17/03/2014 11:02, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: From: Boris BREZILLON Signed-off-by: Boris BREZILLON Signed-off-by: Bo Shen --- Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ 1 file changed, 2

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Boris BREZILLON
Hello Mark, Le 17/03/2014 12:55, Mark Brown a écrit : On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: - compatible: "atmel,asoc-wm8904" - atmel,model: The user-visible name of this sound complex. + - clocks: A list of clocks needed by the wm8904 chip. + -

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Brown
On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: >- compatible: "atmel,asoc-wm8904" >- atmel,model: The user-visible name of this sound complex. > + - clocks: A list of clocks needed by the wm8904 chip. > + - clock-output-names: Driver related clock names. Shall contain "pck0".

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Rutland
On Mon, Mar 17, 2014 at 11:24:41AM +, Boris BREZILLON wrote: > Le 17/03/2014 11:48, Mark Rutland a écrit : > > On Mon, Mar 17, 2014 at 10:18:08AM +, boris brezillon wrote: > >> Hello Mark, > >> > >> Le 17/03/2014 11:02, Mark Rutland a écrit : > >>> On Mon, Mar 17, 2014 at 09:45:40AM +,

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Boris BREZILLON
Le 17/03/2014 11:48, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 10:18:08AM +, boris brezillon wrote: Hello Mark, Le 17/03/2014 11:02, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: From: Boris BREZILLON Signed-off-by: Boris BREZILLON Signed-off-by:

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Rutland
On Mon, Mar 17, 2014 at 10:18:08AM +, boris brezillon wrote: > Hello Mark, > > Le 17/03/2014 11:02, Mark Rutland a écrit : > > On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: > >> From: Boris BREZILLON > >> > >> Signed-off-by: Boris BREZILLON > >> Signed-off-by: Bo Shen > >> --- >

[PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Bo Shen
From: Boris BREZILLON Signed-off-by: Boris BREZILLON Signed-off-by: Bo Shen --- Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Rutland
On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: > From: Boris BREZILLON > > Signed-off-by: Boris BREZILLON > Signed-off-by: Bo Shen > --- > > Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Bo Shen
On 03/17/2014 05:45 PM, Bo Shen wrote: From: Boris BREZILLON Signed-off-by: Boris BREZILLON Signed-off-by: Bo Shen Oh, sorry for my SOB. Please remove it when apply. --- Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Bo Shen
On 03/17/2014 05:45 PM, Bo Shen wrote: From: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Bo Shen voice.s...@atmel.com Oh, sorry for my SOB. Please remove it when apply. ---

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Rutland
On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: From: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Bo Shen voice.s...@atmel.com --- Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ 1 file changed,

[PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Bo Shen
From: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Bo Shen voice.s...@atmel.com --- Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Rutland
On Mon, Mar 17, 2014 at 10:18:08AM +, boris brezillon wrote: Hello Mark, Le 17/03/2014 11:02, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: From: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Boris BREZILLON
Le 17/03/2014 11:48, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 10:18:08AM +, boris brezillon wrote: Hello Mark, Le 17/03/2014 11:02, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: From: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Boris

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Rutland
On Mon, Mar 17, 2014 at 11:24:41AM +, Boris BREZILLON wrote: Le 17/03/2014 11:48, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 10:18:08AM +, boris brezillon wrote: Hello Mark, Le 17/03/2014 11:02, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote:

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Brown
On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: - compatible: atmel,asoc-wm8904 - atmel,model: The user-visible name of this sound complex. + - clocks: A list of clocks needed by the wm8904 chip. + - clock-output-names: Driver related clock names. Shall contain pck0. If this

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Boris BREZILLON
Hello Mark, Le 17/03/2014 12:55, Mark Brown a écrit : On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: - compatible: atmel,asoc-wm8904 - atmel,model: The user-visible name of this sound complex. + - clocks: A list of clocks needed by the wm8904 chip. + - clock-output-names:

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread boris brezillon
Hello Mark, Le 17/03/2014 11:02, Mark Rutland a écrit : On Mon, Mar 17, 2014 at 09:45:40AM +, Bo Shen wrote: From: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Signed-off-by: Bo Shen voice.s...@atmel.com ---

Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-17 Thread Mark Brown
On Mon, Mar 17, 2014 at 02:44:00PM +0100, Boris BREZILLON wrote: Le 17/03/2014 12:55, Mark Brown a écrit : On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: If this is a clock for the CODEC it should be documented as part of the binding for the CODEC and connected to the CODEC in the