Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/16/2017 03:46 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> >> Signed-off-by: Jens

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/16/2017 03:46 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> >> Signed-off-by: Jens Axboe > ... >>

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe ... > + > +static void

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe ... > + > +static void dd_merged_requests(struct

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 02 feb 2017, alle ore 22:32, Jens Axboe ha scritto: > > On 02/02/2017 02:15 PM, Paolo Valente wrote: >> >>> Il giorno 02 feb 2017, alle ore 16:30, Jens Axboe ha scritto: >>> >>> On 02/02/2017 02:19 AM, Paolo Valente wrote: The scheme is clear.

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 02 feb 2017, alle ore 22:32, Jens Axboe ha scritto: > > On 02/02/2017 02:15 PM, Paolo Valente wrote: >> >>> Il giorno 02 feb 2017, alle ore 16:30, Jens Axboe ha scritto: >>> >>> On 02/02/2017 02:19 AM, Paolo Valente wrote: The scheme is clear. One comment, in case it could

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/02/2017 02:15 PM, Paolo Valente wrote: > >> Il giorno 02 feb 2017, alle ore 16:30, Jens Axboe ha scritto: >> >> On 02/02/2017 02:19 AM, Paolo Valente wrote: >>> The scheme is clear. One comment, in case it could make sense and >>> avoid more complexity: since put_rq_priv is

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/02/2017 02:15 PM, Paolo Valente wrote: > >> Il giorno 02 feb 2017, alle ore 16:30, Jens Axboe ha scritto: >> >> On 02/02/2017 02:19 AM, Paolo Valente wrote: >>> The scheme is clear. One comment, in case it could make sense and >>> avoid more complexity: since put_rq_priv is invoked in two

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 02 feb 2017, alle ore 16:30, Jens Axboe ha scritto: > > On 02/02/2017 02:19 AM, Paolo Valente wrote: >> The scheme is clear. One comment, in case it could make sense and >> avoid more complexity: since put_rq_priv is invoked in two different >> contexts, process or

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 02 feb 2017, alle ore 16:30, Jens Axboe ha scritto: > > On 02/02/2017 02:19 AM, Paolo Valente wrote: >> The scheme is clear. One comment, in case it could make sense and >> avoid more complexity: since put_rq_priv is invoked in two different >> contexts, process or interrupt, I

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/02/2017 02:19 AM, Paolo Valente wrote: > The scheme is clear. One comment, in case it could make sense and > avoid more complexity: since put_rq_priv is invoked in two different > contexts, process or interrupt, I didn't feel so confusing that, when > put_rq_priv is invoked in the context

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/02/2017 02:19 AM, Paolo Valente wrote: > The scheme is clear. One comment, in case it could make sense and > avoid more complexity: since put_rq_priv is invoked in two different > contexts, process or interrupt, I didn't feel so confusing that, when > put_rq_priv is invoked in the context

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 02 feb 2017, alle ore 06:19, Jens Axboe ha scritto: > > On 02/01/2017 04:11 AM, Paolo Valente wrote: >>> +static bool dd_bio_merge(struct blk_mq_hw_ctx *hctx, struct bio *bio) >>> +{ >>> + struct request_queue *q = hctx->queue; >>> + struct deadline_data *dd =

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 02 feb 2017, alle ore 06:19, Jens Axboe ha scritto: > > On 02/01/2017 04:11 AM, Paolo Valente wrote: >>> +static bool dd_bio_merge(struct blk_mq_hw_ctx *hctx, struct bio *bio) >>> +{ >>> + struct request_queue *q = hctx->queue; >>> + struct deadline_data *dd =

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/01/2017 04:56 AM, Paolo Valente wrote: >> +/* >> + * add rq to rbtree and fifo >> + */ >> +static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request >> *rq, >> + bool at_head) >> +{ >> +struct request_queue *q = hctx->queue; >> +struct

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/01/2017 04:56 AM, Paolo Valente wrote: >> +/* >> + * add rq to rbtree and fifo >> + */ >> +static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request >> *rq, >> + bool at_head) >> +{ >> +struct request_queue *q = hctx->queue; >> +struct

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/01/2017 04:11 AM, Paolo Valente wrote: >> +static bool dd_bio_merge(struct blk_mq_hw_ctx *hctx, struct bio *bio) >> +{ >> +struct request_queue *q = hctx->queue; >> +struct deadline_data *dd = q->elevator->elevator_data; >> +int ret; >> + >> +spin_lock(>lock); >> +ret =

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 02/01/2017 04:11 AM, Paolo Valente wrote: >> +static bool dd_bio_merge(struct blk_mq_hw_ctx *hctx, struct bio *bio) >> +{ >> +struct request_queue *q = hctx->queue; >> +struct deadline_data *dd = q->elevator->elevator_data; >> +int ret; >> + >> +spin_lock(>lock); >> +ret =

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > --- > block/Kconfig.iosched |

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > --- > block/Kconfig.iosched | 6 + > block/Makefile

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > --- > block/Kconfig.iosched |

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > --- > block/Kconfig.iosched | 6 + > block/Makefile

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On Fri, Jan 20 2017, Paolo Valente wrote: > > > Il giorno 20 gen 2017, alle ore 14:14, Paolo Valente > > ha scritto: > > > >> > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha > >> scritto: > >> > >> This is basically identical to

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On Fri, Jan 20 2017, Paolo Valente wrote: > > > Il giorno 20 gen 2017, alle ore 14:14, Paolo Valente > > ha scritto: > > > >> > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha > >> scritto: > >> > >> This is basically identical to deadline-iosched, except it registers > >> as a MQ

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On Fri, Jan 20 2017, Paolo Valente wrote: > > > Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > > > This is basically identical to deadline-iosched, except it registers > > as a MQ capable scheduler. This is still a single queue design. > > > > Jens, > no

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On Fri, Jan 20 2017, Paolo Valente wrote: > > > Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > > > This is basically identical to deadline-iosched, except it registers > > as a MQ capable scheduler. This is still a single queue design. > > > > Jens, > no spin_lock_irq* in

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On Fri, Jan 20 2017, Paolo Valente wrote: > > > Il giorno 17 gen 2017, alle ore 03:47, Jens Axboe ha scritto: > > > > On 12/22/2016 09:49 AM, Paolo Valente wrote: > >> > >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha > >>> scritto: > >>> > >>> This is

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On Fri, Jan 20 2017, Paolo Valente wrote: > > > Il giorno 17 gen 2017, alle ore 03:47, Jens Axboe ha scritto: > > > > On 12/22/2016 09:49 AM, Paolo Valente wrote: > >> > >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha > >>> scritto: > >>> > >>> This is basically identical to

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 20 gen 2017, alle ore 14:14, Paolo Valente > ha scritto: > >> >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 20 gen 2017, alle ore 14:14, Paolo Valente > ha scritto: > >> >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> > >

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > Jens, no spin_lock_irq* in the code. So, also request dispatches are

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > Jens, no spin_lock_irq* in the code. So, also request dispatches are guaranteed to

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 gen 2017, alle ore 03:47, Jens Axboe ha scritto: > > On 12/22/2016 09:49 AM, Paolo Valente wrote: >> >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >>> >>> This is basically identical to deadline-iosched, except it registers >>>

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 gen 2017, alle ore 03:47, Jens Axboe ha scritto: > > On 12/22/2016 09:49 AM, Paolo Valente wrote: >> >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >>> >>> This is basically identical to deadline-iosched, except it registers >>> as a MQ capable scheduler.

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/22/2016 09:49 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> > > One last question

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/22/2016 09:49 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> > > One last question (for today

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/22/2016 09:07 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> >> Signed-off-by: Jens

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/22/2016 09:07 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> >> Signed-off-by: Jens Axboe >> --- >

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > One last question (for today ...):in mq-deadline there are no "schedule

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > One last question (for today ...):in mq-deadline there are no "schedule dispatch" or

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > --- ... > diff --git

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > --- ... > diff --git a/block/mq-deadline.c

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/21/2016 04:59 AM, Bart Van Assche wrote: > Since this patch is the first patch that introduces a call to > blk_queue_exit() from a module other than the block layer core, > shouldn't this patch export the blk_queue_exit() function? An attempt > to build mq-deadline as a module resulted in

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/21/2016 04:59 AM, Bart Van Assche wrote: > Since this patch is the first patch that introduces a call to > blk_queue_exit() from a module other than the block layer core, > shouldn't this patch export the blk_queue_exit() function? An attempt > to build mq-deadline as a module resulted in

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/17/2016 01:12 AM, Jens Axboe wrote: > +static bool dd_put_request(struct request *rq) > +{ > + /* > +  * If it's a real request, we just have to free it. For a shadow > +  * request, we should only free it if we haven't started it. A > +  * started request is mapped to a real

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/17/2016 01:12 AM, Jens Axboe wrote: > +static bool dd_put_request(struct request *rq) > +{ > + /* > +  * If it's a real request, we just have to free it. For a shadow > +  * request, we should only free it if we haven't started it. A > +  * started request is mapped to a real

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/20/2016 02:34 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> >> Signed-off-by: Jens

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On 12/20/2016 02:34 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is still a single queue design. >> >> Signed-off-by: Jens Axboe >> ... >>

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > ... > + > +static bool

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > > Signed-off-by: Jens Axboe > ... > + > +static bool dd_has_work(struct blk_mq_hw_ctx

[PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

This is basically identical to deadline-iosched, except it registers as a MQ capable scheduler. This is still a single queue design. Signed-off-by: Jens Axboe --- block/Kconfig.iosched | 6 + block/Makefile| 1 + block/mq-deadline.c | 649

[PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

This is basically identical to deadline-iosched, except it registers as a MQ capable scheduler. This is still a single queue design. Signed-off-by: Jens Axboe --- block/Kconfig.iosched | 6 + block/Makefile| 1 + block/mq-deadline.c | 649